Conversation
macrouch
requested review from
eudoroolivares2016,
mandyparson,
stephenkilbourn and
trevorlang
August 20, 2026 17:17
Bundle Size ComparisonFull build detailsThe full bundle is smaller than main by -0.14 kB. 🎉 The index.js is larger than main by 0.01 kB. ❗ Run
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2081 +/- ##
==========================================
- Coverage 95.85% 95.84% -0.02%
==========================================
Files 756 756
Lines 17773 17776 +3
Branches 4978 4978
==========================================
+ Hits 17037 17038 +1
- Misses 684 686 +2
Partials 52 52 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| if ( | ||
| collectionId === zustandState.granules.granules.collectionConceptId | ||
| && !isOpenSearch | ||
| !collectionId |
Contributor
There was a problem hiding this comment.
Should we put this catch further up if (!collectionId) return on something like line 49? if the coll is empty do we need to execute anything else on this slice instead bail?
Contributor
Author
There was a problem hiding this comment.
I originally had it further up but I was looking at what was triggering it, and the bug is because of the opensearch double trigger mentioned in the comments. So I moved it into this if statement. I meant to add details to that comment, I'll do that now
eudoroolivares2016
approved these changes
Aug 20, 2026
mandyparson
approved these changes
Aug 20, 2026
…es timeout for moving map to shapefile after the projection changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature?
Fixes granules requests with no collection concept id. When getGranules is called with no collectionConceptId, return without fetching granules because that is an invalid request to CMR
Additionally I think I fixed the playwright flakiness. I blocked tophat from loading in playwright tests, and I ensured that the tophat container remained the same size. After that I made a few other minor playwright changes and retook every screenshot. I got two runs in a row with no failures.
What areas of the application does this impact?
Granules
Testing
Reproduction steps
From the collection results page, click on a collection to view granules (or to view collection details), then immediate press the back button (either browser back or "Search Results (# Collections)" link.
Ensure that the red error banner is not displayed
Checklist
npm audit fixand made note of any changes in this PR