Skip to content

test: use current user for archive ownership in breakout tests #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thaJeztah merged 1 commit into from
Jul 22, 2026
Merged

test: use current user for archive ownership in breakout tests #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions utils_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,15 @@ import (
"io"
"os"
"path/filepath"
"runtime"
"time"
)

var testUntarFns = map[string]func(string, io.Reader) error{
"untar": func(dest string, r io.Reader) error {
return Untar(r, dest, nil)
return Untar(r, dest, &TarOptions{
NoLchown: true,
})
},
"applylayer": func(dest string, r io.Reader) error {
_, err := ApplyLayer(dest, r)
Expand Down Expand Up @@ -64,11 +67,21 @@ func testBreakout(untarFn string, tmpdir string, headers []*tar.Header) error {

reader, writer := io.Pipe()
go func() {
t := tar.NewWriter(writer)
tw := tar.NewWriter(writer)
var uid, gid int
if runtime.GOOS != "windows" {
uid, gid = os.Getuid(), os.Getgid()
}
for _, hdr := range headers {
_ = t.WriteHeader(hdr)
// Use the current user to avoid unrelated EPERM failures from applying
// archive ownership. ApplyLayer always applies archive ownership and
// does not support TarOptions.NoLchown.
hdr := *hdr
hdr.Uid = uid
hdr.Gid = gid
_ = tw.WriteHeader(&hdr)
}
_ = t.Close()
_ = tw.Close()
}()

untar := testUntarFns[untarFn]
Expand Down
Loading