Skip to content

test: use current user for archive ownership in breakout tests - #72

Merged
thaJeztah merged 1 commit into
moby:mainfrom
thaJeztah:no_chown
Jul 22, 2026
Merged

test: use current user for archive ownership in breakout tests#72
thaJeztah merged 1 commit into
moby:mainfrom
thaJeztah:no_chown

Conversation

@thaJeztah

Copy link
Copy Markdown
Member

Set archive entry UID/GID to the current user when generating test archives. This avoids unrelated chown failures when running unprivileged, while still exercising the breakout detection logic.

In particular, ApplyLayer always applies archive ownership and does not support NoLchown, so using the current user keeps the test focused on path validation rather than ownership changes.

Copilot AI review requested due to automatic review settings July 22, 2026 13:57

This comment was marked as off-topic.

Set archive entry UID/GID to the current user when generating test
archives. This avoids unrelated chown failures when running
unprivileged, while still exercising the breakout detection logic.

In particular, ApplyLayer always applies archive ownership and does not
support NoLchown, so using the current user keeps the test focused on
path validation rather than ownership changes.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copilot AI review requested due to automatic review settings July 22, 2026 14:01

This comment was marked as off-topic.

@thaJeztah
thaJeztah merged commit b010281 into moby:main Jul 22, 2026
12 checks passed
@thaJeztah
thaJeztah deleted the no_chown branch July 22, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants