Conversation
|
thanks @diml, I looked into this locally, and discovered that this expands on my system to |
|
oops, sorry, please ignore my comment, I was stuck with a sexplib |
|
Maybe we don't need to add this complexity to the build system and depend unconditionally on the latest version of |
ppx_sexp_conv v0.11.0 compiles successfully, but contains an undesired dependency on base, and is thus still marked as conflicting. This is fixed in ppx_sexp_conv v0.11.1. This commit submits @gasche's fixes from mirleft/ocaml-nocrypto#144 and @diml's fixes from mirleft/ocaml-nocrypto#146
ppx_sexp_conv v0.11.0 compiles successfully, but contains an undesired dependency on base, and is thus still marked as conflicting. This is fixed in ppx_sexp_conv v0.11.1. This commit submits @gasche's fixes from mirleft/ocaml-nocrypto#144 and @diml's fixes from mirleft/ocaml-nocrypto#146
ppx_sexp_conv v0.11.0 compiles successfully, but contains an undesired dependency on base, and is thus still marked as conflicting. This is fixed in ppx_sexp_conv v0.11.1. This commit submits @gasche's fixes from mirleft/ocaml-nocrypto#144 and @diml's fixes from mirleft/ocaml-nocrypto#146
ppx_sexp_conv v0.11.0 compiles successfully, but contains an undesired dependency on base, and is thus still marked as conflicting. This is fixed in ppx_sexp_conv v0.11.1. This commit submits @gasche's fixes from mirleft/ocaml-nocrypto#144 and @diml's fixes from mirleft/ocaml-nocrypto#146
|
Where does this patch/fix stand currently? From what I can see, the current state in opam prevents the use of ppxlib and nocrypto (and therefore tls) in the same project. |
The patches are in opam now, so nocrypto and ppxlib can be used together. The tls issue is being tracked here: mirleft/ocaml-tls#379, and we need to summon @hannesm for that. |
|
Thank you @copy! |
|
master got rid of the sexp stuff now, so I think this PR can be closed? a58c653 |
|
Ping? Sounds like indeed should be closed. |
|
Sure, let's close this |
This PR allows to automatically detect the runtime dependencies of
ppx_sexp_convin order to store them in the META file. This allows ocaml-nocrypto to be compatible with bothppx_sexp_conv< v0.11 and >= v0.11.The method used should work with any ppx rewriter, not just ppx_sexp_conv.