Builds on ocaml 4.07.0 - #5
Closed
ismith wants to merge 3 commits into
Closed
Conversation
This reverts commit 9d1d1d1.
This reverts commit ae6ce58.
Also requires: ``` opam pin -y nocrypto git+https://github.com/gasche/ocaml-nocrypto.git#master-oca mlbuild-pack opam pin -y jwt git+https://github.com/ismith/ocaml-jwt.git#rsa256-verification # rsa256-verification ```
Author
|
Test build on ocaml 4.07.0 using Docker: FROM ubuntu:xenial
ENV ocaml_version 4.07.0
RUN apt update; \
apt install -y apt ocaml-nox zlib1g-dev git curl \
make m4 unzip libgmp-dev pkg-config vim libssl-dev \
software-properties-common; \
apt-add-repository ppa:avsm/ppa; \
apt update; \
apt install -y opam
RUN opam init -a --disable-sandboxing; \
opam switch create $ocaml_version ocaml-base-compiler.$ocaml_version; \
eval $(opam env); \
opam install dune
RUN opam pin -y nocrypto git+https://github.com/gasche/ocaml-nocrypto.git#master-ocamlbuild-pack
RUN opam pin -y jwt git+https://github.com/ismith/ocaml-jwt.git#rsa256-verification # rsa256-verification
RUN opam pin -y gcloud git+https://github.com/ismith/ocaml-gcloud.git#builds-on-ocaml-4.07.0 |
Contributor
|
Interesting, thanks for taking a look! I had a bit of a read of the various nocrypto issue threads, and saw this: So it looks like the other approach for nocrypto+ppx_sexp_conv from this PR is on opam at the minute, although the patches are applied to an older version of nocrypto without the function I tried your Dockerfile with the PR version of @diml's branch that should be on the more up to date version of nocrypto, but got a built error, so happy to merge this unless you can think of another solution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #4 without a lock file, and allows for compatibility with ocaml 4.07.0.
Does require