Skip to content

Fix Android build: remove the dead 1DS Java HTTP bridge #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sheetalarkadam merged 1 commit into from
Aug 10, 2026
+0 −27
Merged

Fix Android build: remove the dead 1DS Java HTTP bridge #964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions sdk_v2/cpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,9 +252,6 @@ set(FOUNDRY_LOCAL_SOURCES

# 1DS bridge — always compiled for Foundry Local Core.
list(APPEND FOUNDRY_LOCAL_SOURCES src/telemetry/one_ds_telemetry.cc)
if(ANDROID)
list(APPEND FOUNDRY_LOCAL_SOURCES src/telemetry/android_telemetry_bridge.cc)
endif()

# Organize headers into filters matching the directory structure in Visual Studio
source_group(TREE "${CMAKE_CURRENT_SOURCE_DIR}" PREFIX "Source" FILES ${FOUNDRY_LOCAL_SOURCES})
Expand Down
12 changes: 0 additions & 12 deletions sdk_v2/cpp/src/telemetry/android_telemetry_bridge.cc
View file
Open in desktop

This file was deleted.

12 changes: 0 additions & 12 deletions sdk_v2/cpp/src/telemetry/one_ds_telemetry.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,6 @@
#include <EventProperties.hpp>
#include "one_ds_tenant_token.h"

#if defined(__ANDROID__)
extern "C" bool FoundryLocalIsAndroidTelemetryReady() noexcept;
#endif

namespace fl {

namespace {
Expand Down Expand Up @@ -192,14 +188,6 @@ OneDsTelemetry::OneDsTelemetry(const std::string& app_name,
"[Telemetry] Disabled via configuration; non-essential 1DS upload disabled "
"(ProcessInfo still uploads)");
}
#if defined(__ANDROID__)
if (!FoundryLocalIsAndroidTelemetryReady()) {
logger_.Log(LogLevel::Information,
"[Telemetry] Android 1DS Java HTTP bridge is not initialized; 1DS upload disabled "
"(events still logged locally)");
return;
}
#endif
const auto token = GetToken();
if (token.empty()) {
logger_.Log(LogLevel::Information,
Expand Down
Loading