Fix Android build: remove the dead 1DS Java HTTP bridge - #964
Merged
Conversation
The C++ core does not compile for Android: android_telemetry_bridge.cc:4:10: fatal error: 'http/HttpClient_Android.hpp' file not found HttpClient_Android.hpp is an internal header of cpp_client_telemetry (upstream lib/http/), and ports/cpp-client-telemetry/portfile.cmake installs only the public mat/ surface, so the include cannot resolve. Installing that header would not have been the fix. The port configures upstream with -DMATSDK_USE_VCPKG_DEPS=ON, and upstream's lib/CMakeLists.txt compiles http/HttpClient_Android.cpp only in the *else* branch of that option; with vcpkg deps, Android builds HttpClient_Curl.cpp instead. Confirmed against the built library: libmat.a for arm64-android defines 0 HttpClient_Android symbols and 37 HttpClient_Curl symbols. Adding the header would have traded a compile error for a link error. So the Java/JNI transport does not exist in this configuration. Android uploads over curl exactly like Linux, and the readiness gate it guarded was asking a question with no meaning here -- it could only ever have suppressed uploads that in fact work. Remove the bridge, the gate, and the source-list entry that pulled it in. No behavioural risk on desktop: the removed code was all inside ANDROID / __ANDROID__ guards. No regression risk on Android either, since telemetry has never compiled there. Verified: clean Android arm64-v8a build (166/166, links) and a Windows RelWithDebInfo build. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 24ef037b-246f-4fea-a1a3-4fae5223cb0c
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sheetalarkadam
marked this pull request as ready for review
August 7, 2026 21:37
sheetalarkadam
requested review from
bmehta001
and
a balanced review from Copilot
August 7, 2026 21:37
bmehta001
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
maindoes not compile for Android:Introduced by #953, which made telemetry mandatory
(
find_package(MSTelemetry CONFIG REQUIRED)) and addedandroid_telemetry_bridge.ccunderif(ANDROID).Fix
The Java/JNI transport does not exist in this configuration: Android uploads
over curl exactly like Linux. T
Removed, subtractively:
src/telemetry/android_telemetry_bridge.cc(whole file)if(ANDROID)source-list entry that pulled it in#if defined(__ANDROID__)declaration and upload gate inone_ds_telemetry.ccRisk
behaviour to regress.
If the Java bridge is wanted on Android for policy or proxy reasons, that is a
separate change: the port would need
MATSDK_USE_VCPKG_DEPS=OFFfor Androidand to install the header. This PR restores the build; it does not close off
that option.
Verification
arm64-v8aRelease build — 166/166 targets, linksRelWithDebInfobuild succeeds; all 20 telemetry unit tests pass