Skip to content

fix: correct UI text and metadata typos - #14847

Open
coolebyak wants to merge 1 commit into
mavlink:masterfrom
coolebyak:fix/english-ui-text-corrections
Open

fix: correct UI text and metadata typos#14847
coolebyak wants to merge 1 commit into
mavlink:masterfrom
coolebyak:fix/english-ui-text-corrections

Conversation

@coolebyak

Copy link
Copy Markdown

Description

This PR consolidates a set of related corrections to user-facing English text across QGroundControl.

This is intended to be a UI-only change. It updates user-facing labels, descriptions, and error messages without changing application logic, settings behavior, runtime identifiers, enum values, or data formats.

It supersedes the previously submitted single-purpose PRs #14828#14833, which were closed at the maintainer's request so the changes could be grouped into a cohesive PR with lower review overhead.

The changes are limited to source strings and metadata. Translation files are intentionally not included and can be updated through the existing Crowdin workflow.

Changes

  • Correct spelling and terminology errors in:
    • General, video, telemetry, UDP, and Remote ID settings
    • Mission planning metadata
    • Pre-flight checklists
    • Video recording and firmware loading error messages
    • EFI and estimator fact descriptions
  • Correct PX4 fixed-wing tuning labels and descriptions:
    • distinguish the Rate and Attitude controller pages
    • correct proportional and feedforward descriptions
    • correct the FW_YR_D gain label and description
    • correct the relative-altitude plot label
  • Clarify misleading settings:
    • rename generic Audio Output controls to Voice Notifications, matching their actual QTextToSpeech behavior
    • describe offline descent speed as descent speed instead of cruising speed
    • clarify that disableWhenDisarmed disables the video stream rather than stopping recording
  • Normalize the MAVLink product name capitalization.

Existing internal identifiers, setting names, enum values, and data formats are unchanged.

Type of Change

  • Bug fix (non-breaking, UI text only)
  • Functional change
  • Breaking change
  • Documentation update
  • Refactoring
  • CI/Build changes

Testing

  • Parsed all 14 modified JSON files successfully
  • Verified that Remote ID enum item counts are unchanged
  • Verified that internal identifiers such as goodAttitudeEsimate are unchanged
  • Ran git diff --check
  • Searched the source tree for the corrected user-facing misspellings
  • Built the complete all target successfully
  • Launched and smoke-tested the application locally

Local build

  • Windows
  • Qt 6.11.1
  • MSVC 2022, 64-bit Release configuration
  • CMake/Ninja build
  • Complete all target finished successfully
  • QGroundControl was launched twice and exited successfully after smoke testing

The runtime emitted an existing QQuickPinchArea.enabled override warning. It is unrelated to the text-only changes in this PR and did not prevent startup or normal shutdown.

No regression test was added because these changes only correct user-facing source strings and metadata.

Platforms Tested

  • Linux
  • Windows
  • macOS
  • Android
  • iOS

Flight Stacks Tested

  • PX4
  • ArduPilot
  • N/A

Screenshots

Not applicable. The changes correct labels, descriptions, and error messages without changing UI layout.

Checklist

  • No translation files were modified
  • No runtime identifiers or enum values were changed
  • The application builds and starts successfully on Windows
  • New and existing automated tests pass locally

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.52%. Comparing base (f29efd3) to head (cdf7ac0).
⚠️ Report is 282 commits behind head on master.

Files with missing lines Patch % Lines
src/Vehicle/VehicleSetup/FirmwareImage.cc 0.00% 1 Missing ⚠️
src/VideoManager/VideoManager.cc 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (30.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14847      +/-   ##
==========================================
+ Coverage   25.47%   33.52%   +8.05%     
==========================================
  Files         769      928     +159     
  Lines       65912    84101   +18189     
  Branches    30495    38868    +8373     
==========================================
+ Hits        16788    28193   +11405     
+ Misses      37285    36900     -385     
- Partials    11839    19008    +7169     
Flag Coverage Δ
unittests 33.52% <0.00%> (+8.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Vehicle/VehicleSetup/FirmwareImage.cc 0.00% <0.00%> (ø)
src/VideoManager/VideoManager.cc 8.02% <0.00%> (+6.12%) ⬆️

... and 633 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36e35b8...cdf7ac0. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Build Results

Platform Status

Platform Status Details
Linux Passed View
Windows Passed View
MacOS Passed View
Android Passed View

All builds passed.

Pre-commit

Check Status Details
pre-commit Failed (non-blocking) View

Pre-commit hooks: 2 passed, 75 failed, 7 skipped.

Test Results

linux-coverage-integration: 43 passed, 0 skipped
linux-coverage-unit: 130 passed, 0 skipped
linux-sanitizers-integration: 25 passed, 0 skipped
linux-sanitizers-unit: 130 passed, 0 skipped
Total: 328 passed, 0 skipped

Code Coverage

Coverage: 69.0%

No baseline available for comparison

Artifact Sizes

Artifact Size
QGroundControl 252.55 MB
QGroundControl-aarch64 176.45 MB
QGroundControl-installer-AMD64 137.89 MB
QGroundControl-installer-AMD64-ARM64 80.41 MB
QGroundControl-installer-ARM64 109.16 MB
QGroundControl-linux 84.47 MB
QGroundControl-mac 84.46 MB
QGroundControl-x86_64 188.68 MB
No baseline available for comparison

Updated: 2026-08-12 06:23:20 UTC • Commit: cdf7ac0 • Triggered by: Windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant