Gimbal: help tell multiple gimbal managers apart - #14793
Merged
Merged
Conversation
23 tasks
Contributor
Build ResultsPlatform Status
Some builds failed. Pre-commit
Pre-commit hooks: 0 passed, 0 failed, 0 skipped. Updated: 2026-08-11 20:47:09 UTC • Commit: 9b81700 • Triggered by: Linux |
Contributor
Author
|
@DonLakeFlyer what about adding this to v5.1 and #14794 to v5.2? |
Contributor
I can live with that. Can you change this such that you build gimbal names using a common function? You basically have the gimbal name building in two different places, done two different ways (sort of). |
Contributor
Author
Good idea. |
Contributor
Author
|
Done. |
When we have more than one gimbal manager in the system, it is not clear which gimbal is which. For example: - Autopilot with internal gimbal (compid 1, gimbal device 1) - External Mavlink gimbal manager (compid 154, gimbal device 1) Previously, both of these gimbals would show as "Gimbal 1". With this change, they show up as "Gimbal 1-1" and "Gimbal 154-1".
DonLakeFlyer
force-pushed
the
pr-multiple-gimbal-managers
branch
from
August 11, 2026 20:45
9b81700 to
4f57380
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When we have more than one gimbal manager in the system, it is not clear which gimbal is which.
For example:
Previously, both of these gimbals would show as "Gimbal 1".
With this change, they show up as "Gimbal 1-1" and "Gimbal 154-1".
Type of Change
Testing
Platforms Tested
Flight Stacks Tested
Screenshots
Checklist
Related Issues
By submitting this pull request, I confirm that my contribution is made under the terms of the project's dual license (Apache 2.0 and GPL v3).