[dv,chip] Add a working rom_ctrl skip-middle at chip-level for Earlgrey - #30990
Open
rswarbrick wants to merge 1 commit into
Open
[dv,chip] Add a working rom_ctrl skip-middle at chip-level for Earlgrey#30990rswarbrick wants to merge 1 commit into
rswarbrick wants to merge 1 commit into
Conversation
rswarbrick
force-pushed
the
skip-plusarg-at-chip-level
branch
2 times, most recently
from
August 14, 2026 13:13
ba4ec87 to
cc024e3
Compare
vogelpi
approved these changes
Aug 14, 2026
vogelpi
left a comment
Contributor
There was a problem hiding this comment.
Thanks @rswarbrick , this looks very nice!
rswarbrick
force-pushed
the
skip-plusarg-at-chip-level
branch
from
August 18, 2026 10:41
cc024e3 to
9e992ac
Compare
rswarbrick
marked this pull request as ready for review
August 18, 2026 10:41
This works by running a copy of rom_ctrl_skip_middle_with_digest_vseq to force the address and also the digest responses in rom_ctrl, causing it to skip over reading the ROM at the start of the test. The only other tricky thing that needs doing is to disable some of the checks in the bound-in rom_ctrl_scoreboard. The problem is that we force the signals when they arrive at the FSM. This is much easier, because it's rather messy to get a hierarchical up-reference to a port of rom_ctrl itself. To do so would mean that rom_ctrl_bound_if would need all the parameters of rom_ctrl itself and then would have to refer to it with all of them. If we just force a signal on a port of the FSM, that works perfectly well... except that rom_ctrl_scoreboard can't see that we forced it! I think the right thing to do in this situation is just to disable the checks that are based on knowing what the KMAC response contained. Signed-off-by: Rupert Swarbrick <rswarbrick@lowrisc.org>
rswarbrick
force-pushed
the
skip-plusarg-at-chip-level
branch
from
August 18, 2026 11:52
9e992ac to
44b9b62
Compare
Contributor
Author
|
Changes in force-push (prompted by review from the Claude tool):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the PRs needed by the PR have been merged, it just contains the following commit:
This now allows a trivial change to turn on the behaviour by passing
+skip_middle_of_rom=1in tests that should use the machinery.