chore(CategoryTheory/Presentable): remove a backward.isDefEq set_option - #42984
chore(CategoryTheory/Presentable): remove a backward.isDefEq set_option#42984dennj wants to merge 6 commits into
Conversation
PR summary b67a2995feImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type (strong) |
|---|---|---|
| 2560 | -1 | backward.isDefEq.respectTransparency.types |
Current commit b67a2995fe
Reference commit 9b397f578e
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
YaelDillies
left a comment
There was a problem hiding this comment.
Which type is being abused here? Do you know?
It's not ToType. The aesop call fails without the flag even for a generic f : ι → β, so it's the subtype ↥(Set.range f): aesop needs to unfold · ∈ Set.range f inside the type to close the goal, and the flag allows that. The explicit rintro proof doesn't touch the type, so the flag can go. |
|
Ideally we would like |
Nothing is missing from aesop: the problem was the term |
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
YaelDillies
left a comment
There was a problem hiding this comment.
Thanks! 🚀
maintainer merge
|
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
|
Thanks! bors merge |
|
Build failed: Fix if necessary, and then someone with permission can run |
See #42925