Repository navigation
Update Eigen to 3.4.1 and verify CLI numerical parity - #5
Merged
Merged
Conversation
lanxinger
marked this pull request as ready for review
October 2, 2026 15:25
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update vendored Eigen from 3.4.0 to 3.4.1 using the checksum-verified upstream archive. CMake now uses the same vendored headers as SwiftPM, keeping numerical behavior consistent across the build matrix. The CLI numerical golden check runs through CTest on macOS, Linux, and Windows.
Validation: all 73 Swift package tests passed locally, including native CPU/GPU parity; the macOS Release CLI output is byte-for-byte identical to the existing golden fixture; CTest, actionlint, and whitespace checks passed. Vendored Eigen headers match the upstream archive exactly. Hosted validation passed: the Release CLI build and numerical golden CTest on macOS, Linux, and Windows, plus all 73 macOS Swift package tests. CI run.