Repository navigation
Migrate tinygltf to 3.0.1 with GLB fixture and numerical parity checks - #6
Merged
Merged
Conversation
lanxinger
marked this pull request as ready for review
October 2, 2026 15:26
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the CLI glTF/GLB loader from tinygltf 2.9.7 to the checksum-pinned 3.0.1 C11 runtime. Port scene traversal, accessors, diagnostics, and model ownership to the v3 API. Column-major matrices and scene-root selection are corrected; buffer reads are bounded, and cyclic/repeated nodes and malformed geometry fail explicitly. Indexed triangles with dense float32 positions remain the supported import contract.
This PR is stacked on the Eigen update in #5. Generated GLB/glTF fixtures cover 8/16/32-bit indices, interleaved positions, embedded/external buffers, nested matrix/TRS transforms, scene selection, mesh instances, deep hierarchies, and malformed input. They compare denoised geometry with equivalent OBJ inputs; the existing golden fixture remains unchanged. The fixture suite runs in the macOS/Linux/Windows CI matrix.
Validation: the macOS Release build and all nine CLI tests passed locally; the same tests passed with the CLI and new parser compiled under AddressSanitizer/UndefinedBehaviorSanitizer. The new transform/root fixtures fail against the previous loader as expected. Ruff, actionlint, and whitespace checks passed. The preceding Eigen update passed all 73 Swift package tests. Hosted validation passed: the Release CLI build and GLB/golden CTest suite on macOS, Linux, and Windows, plus all 73 macOS Swift package tests. CI run.