Skip to content

Include the library root modules in each lean_lib #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JasonGross wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Include the library root modules in each lean_lib #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions lakefile.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,20 @@ package «lean-zip-common» where
-- Both libraries are default targets, so a bare `lake build` (what CI runs)
-- actually builds them. Without this Lake has nothing to do and reports
-- "Build completed successfully (0 jobs)".
--
-- `.andSubmodules`, not `.submodules`: the latter excludes the root module
-- itself, so `ZipForStd.lean`/`ZipCommon.lean` were left out of the library.
-- A shared library built from such a lib has no `initialize_<lib>` symbol, and
-- a dependent package with `precompileModules := true` then fails to load it
-- ("error loading plugin, initializer not found
-- 'initialize_lean_x2dzip_x2dcommon_ZipForStd'").
@[default_target]
lean_lib ZipForStd where
globs := #[.submodules `ZipForStd]
globs := #[.andSubmodules `ZipForStd]

@[default_target]
lean_lib ZipCommon where
globs := #[.submodules `ZipCommon]
globs := #[.andSubmodules `ZipCommon]

-- IO FFI (Handle seek/fileSize shims — no external library deps)
input_file io_ffi.c where
Expand Down