Include the library root modules in each lean_lib - #5
Draft
JasonGross wants to merge 1 commit into
Draft
Conversation
`globs := #[.submodules `X]` selects the submodules of `X` but not `X`
itself, so `ZipForStd.lean` and `ZipCommon.lean` were not members of their
own libraries. A shared library built from such a `lean_lib` therefore has
no `initialize_<lib>` symbol, and a dependent package built with
`precompileModules := true` fails to load it:
error loading plugin, initializer not found
'initialize_lean_x2dzip_x2dcommon_ZipForStd'
`.andSubmodules` selects the root module too.
Patch authored by Claude Fable 5 (Anthropic's Claude Code).
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TK6r4jXLa2tKRNP9orsXN6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each
lean_libselects#[.submodulesX], which matches the submodules ofXbut notXitself, soZipForStd.leanandZipCommon.leanare not members of their own libraries;.andSubmodulesincludes the root module too. This matters because a shared library built from such alean_libhas noinitialize_symbol, so any dependent package built withprecompileModules := truefails to load it witherror loading plugin, initializer not found 'initialize_lean_x2dzip_x2dcommon_ZipForStd'`. Patch authored by Claude Fable 5 (Anthropic's Claude Code).