Fix ArgumentOutOfRangeExecption with 0xffff parameters - #977
Open
ItsZil wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #913 and improves the original unmerged fix in PR #914.
The fix provided in PR #914 is insufficient in certain cases due to this condition:
current_index + 1 == current_table.LengthThe above condition causes the fix to apply only when the overflow is on the second-to-last row of the method metadata table. But if there are additional parameterless methods at the end of the table, the parameter metadata table does not grow together with the method table. This causes the overflow to occur further from the end of the table.
The fix is simple: remove the above condition altogether. This is safe because
next_indexcan never be 0 when the parameters table is exactly0xffff.Note that the same issue also applies to
dnlib, as it also checks fortableSourceRid + 1 == tableSource.Rows.I added a test which uses the same module as param0xffff.dll, but adds a couple of extra parameterless methods on top, which move the overflow away from the second-to-last row.