Skip to content

Fix issue with 0xffff parameters - #914

Open
jbevain wants to merge 2 commits into
masterfrom
param0xffff
Open

Fix issue with 0xffff parameters#914
jbevain wants to merge 2 commits into
masterfrom
param0xffff

Conversation

@jbevain

@jbevain jbevain commented Jun 23, 2023

Copy link
Copy Markdown
Owner

Fix #913

@alexey-zakharov

Copy link
Copy Markdown

Hey @jbevain !

Are there any reasons to not merge this PR? 😄

@xoofx

xoofx commented Dec 16, 2024

Copy link
Copy Markdown

Hey @jbevain, After discussing with @alexey-zakharov we believe that it is the right fix. We did a similar fix in Unity-Technologies/mono#2081, it is non breaking and fixing an actual issue. We plan to port also this fix to CoreCLR. Could you merge this PR and release a new package?

@ItsZil

ItsZil commented Mar 10, 2026

Copy link
Copy Markdown

Hi @jbevain, I put up PR #977, which changes your fix very slightly to fix cases where there is an overflow due to extra parameterless methods. Can you please check whether that fix could be merged instead of this one? Thanks 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible ArgumentOutOfRangeException when there are 65535 params in metadata table

4 participants