-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Match prim path expressions as whole-path regular expressions #6841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ooctipus
merged 17 commits into
isaac-sim:develop
from
ooctipus:octi/prim-path-real-regex-matcher
Aug 14, 2026
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
58984ac
Match prim path expressions as whole-path regular expressions
ooctipus 0cbce75
Split prim path expressions on separators, not on every slash
ooctipus 4785ea6
Match the env slot by shape, not by one spelling
ooctipus cbd37de
Spell prim path wildcards as regex at every boundary
ooctipus e033774
Resolve a leftover deformable wildcard in any spelling
ooctipus 91c453b
Spell the ovphysx sensor test paths as regex
ooctipus 05bfa7e
Let a configuration name the env namespace by macro
ooctipus a85ea65
Name the env namespace by macro in the tests too
ooctipus 0f18509
Convert the cable articulation pattern at the boundary
ooctipus 058c33f
Name the env namespace by macro in the humanoid sensor too
ooctipus 0884250
Merge upstream/develop into prim-path matcher
ooctipus 312fe8c
Remove regex-inferred traversal bounds
ooctipus 3a3743b
Merge branch 'develop' into octi/prim-path-real-regex-matcher
ooctipus a4be8bd
Fix clone-scoped prim regex matching
ooctipus 789ac9d
Merge branch 'develop' into octi/prim-path-real-regex-matcher
ooctipus c79fd0b
Simplify clone-scoped regex discovery
ooctipus ce4424a
Keep legacy regex fallback unscoped
ooctipus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
62 changes: 62 additions & 0 deletions
62
source/isaaclab/changelog.d/octi-prim-path-real-regex-matcher.minor.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| Added | ||
| ^^^^^ | ||
|
|
||
| * Added :attr:`~isaaclab.cloner.CloneCfg.clone_template` for the replicated environment prim path, | ||
| with ``{}`` marking the environment index. It replaces ``CloneCfg.clone_regex``, whose value is | ||
| now ``clone_template.format("[^/]+")``. | ||
| * Added an ``env_template`` argument to :func:`~isaaclab.cloner.make_clone_plan` and | ||
| :class:`~isaaclab.cloner.ReplicateSession`. | ||
| * Added :func:`~isaaclab.sim.utils.path_expr_to_glob` and | ||
| :func:`~isaaclab.sim.utils.split_path_expr`, for converting a prim path expression to the glob | ||
| the physics engines accept and for splitting one without cutting a character class in half. | ||
| * Added :func:`~isaaclab.cloner.expand_env_regex_ns`, and applied it when an asset or a sensor is | ||
| constructed. ``{ENV_REGEX_NS}`` previously only resolved for assets a | ||
| :class:`~isaaclab.scene.InteractiveScene` collected, so a direct environment -- which builds its | ||
| own -- had to spell the namespace out. Either kind may now use the macro, and no configuration | ||
| has to name the wildcard that selects one environment. | ||
|
|
||
| Changed | ||
| ^^^^^^^ | ||
|
|
||
| * **Breaking:** Changed :func:`~isaaclab.sim.utils.find_matching_prims` to match the whole prim | ||
| path as a plain regular expression instead of one token per path segment. ``.`` now matches | ||
| ``/``, so ``/World/Robot/.*`` selects descendants at any depth; use ``[^/]+`` for a single | ||
| segment. Unscoped queries test every authored prim, including inactive and undefined prims and | ||
| instance proxies, without inferring a traversal root or depth limit from the expression. | ||
| Clone-aware discovery instead rebases the expression through the active clone plan and searches | ||
| only its concrete source subtree, never every cloned destination environment. | ||
| * Changed :func:`~isaaclab.sim.utils.find_first_matching_prim` to delegate to | ||
| :func:`~isaaclab.sim.utils.find_matching_prims`, so both read an expression the same way. | ||
| * Changed the environment namespace to spell its slot ``[^/]+`` rather than ``.*``, so | ||
| ``{ENV_REGEX_NS}/Robot`` no longer also selects a ``Robot`` nested deeper under an environment. | ||
| * Changed :func:`~isaaclab.cloner.path.match` to accept a character class in the clone slot, so a | ||
| segment-safe namespace resolves against a destination template. | ||
|
|
||
| * Changed prim path expressions throughout the repository to spell a single path segment | ||
| ``[^/]`` rather than ``.``, so each pattern selects what it selected before now that ``.`` | ||
| matches ``/``. | ||
|
|
||
| Removed | ||
| ^^^^^^^ | ||
|
|
||
| * Removed the legacy glob-wildcard rewrite from prim path expressions. A bare ``*`` is a regular | ||
| expression quantifier and is no longer rewritten to ``.*``; the rewrite could not tell a glob | ||
| star from a quantifier and corrupted ``[^/]*`` into ``[^/].*``. Patterns relying on ``*`` as a | ||
| standalone wildcard should spell it ``.*`` (any depth) or ``[^/]*`` (one path segment). | ||
|
|
||
| Fixed | ||
| ^^^^^ | ||
|
|
||
| * Fixed :func:`~isaaclab.cloner.make_clone_plan` raising ``IndexError`` for a prim path holding | ||
| more than one wildcard, and ignoring a non-default environment namespace. | ||
| * Fixed :class:`~isaaclab.sensors.MultiMeshRayCaster` expanding ``{ENV_REGEX_NS}`` with a | ||
| hardcoded namespace instead of the shared default. | ||
| * Fixed callers that split a prim path expression on ``/`` cutting a ``[^/]`` character class in | ||
| half, which raised ``re.error: unterminated character set`` or produced a truncated body name. | ||
| * Fixed :func:`~isaaclab.sim.spawn_multi_asset` rejecting an index slot spelled ``[^/]*``; the | ||
| slot is now any segment wildcard rather than a literal ``.*``. | ||
| * Fixed callers that substituted a concrete environment index into a path expression by matching | ||
| one spelling of the environment slot, so a namespace written with a different quantifier was | ||
| left unresolved: the visualizer camera view, and the deformable render bindings. | ||
| * Fixed :func:`~isaaclab.cloner.query.path_to_source` reporting its destination as a glob, which | ||
| matched nothing when a caller used it as the path expression its name promises. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.