Skip to content

Fix AliSim crashing when using GHOST with a partitioned/mixed-datatype models #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bqminh merged 1 commit into from
Sep 4, 2026
Merged

Fix AliSim crashing when using GHOST with a partitioned/mixed-datatype models #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions simulator/alisimulator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,10 +166,15 @@ void AliSimulator::initializeIQTreeFromTreeFile()

// set the new PhyloTreeMixlen to the new tree
current_tree = new_tree;


// update the pointer stored in the super tree's vector of partition
// trees; otherwise it keeps referencing the just-deleted old tree,
// causing a dangling-pointer crash later (e.g. in initSequences())
((PhyloSuperTree*) tree)->at(i) = current_tree;

// re-load the tree/branch-lengths from the file
current_tree->IQTree::readTree(params->user_file, is_rooted, tree_line_index);

// re-initialize the model
initializeModel(current_tree, current_tree->aln->model_name);
}
Expand Down
Loading