Fix AliSim crashing when using GHOST with a partitioned/mixed-datatype models - #191
Merged
Conversation
…ation reported at #537 (in the iqtree2 repo) because of a deleted tree pointer
Contributor
|
Hi @trongnhanuit, This issue has already been solved in #182 in a much more general way. No need for a duplicate solution. Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a crash when AliSim simulates alignments using GHOST with partitioned/mixed-datatype models because of a deleted tree pointer. This bug was reported in the iqtree2 repo.
Solution: set the pointer to the correct (newly-created) PhyloTreeMixlen tree.