Skip to content

Adapt to elvis_core 5.x #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elbrujohalcon merged 20 commits into from
Mar 14, 2026
Merged

Adapt to elvis_core 5.x #602

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
723c08e
Adapt to elvis_core 5.x
paulo-ferraz-oliveira Mar 11, 2026
1918cad
Turn it around (warnings_as_errors, on by default)
paulo-ferraz-oliveira Mar 12, 2026
ec9b930
Fix spec
paulo-ferraz-oliveira Mar 12, 2026
1ddd0e8
Fix for compiler warnings
paulo-ferraz-oliveira Mar 12, 2026
3e920d7
Bump to elvis_core 5.0.0
paulo-ferraz-oliveira Mar 12, 2026
3d7650c
Act on newer constraints
paulo-ferraz-oliveira Mar 13, 2026
98f79ff
Remove useless mechanism (moved to elvis_core)
paulo-ferraz-oliveira Mar 13, 2026
54d6e0a
Simplify it
paulo-ferraz-oliveira Mar 13, 2026
f0b6839
Adapt to newer elvis_core, which also simplifies it for us
paulo-ferraz-oliveira Mar 13, 2026
9841ba3
Be consistent with elvis_core
paulo-ferraz-oliveira Mar 13, 2026
50bf382
Be consistent internally
paulo-ferraz-oliveira Mar 13, 2026
bbb82da
Fix per visual inspection
paulo-ferraz-oliveira Mar 13, 2026
cb4bf88
Ease review
paulo-ferraz-oliveira Mar 13, 2026
4d8d51f
Accept review suggestion
paulo-ferraz-oliveira Mar 13, 2026
8ceff13
Accept review suggestion
paulo-ferraz-oliveira Mar 13, 2026
17a8772
Prepare for 5.0.0+
paulo-ferraz-oliveira Mar 13, 2026
a897822
Forgot to run erlfmt? yes!
paulo-ferraz-oliveira Mar 13, 2026
62b05ec
Fix per testing
paulo-ferraz-oliveira Mar 13, 2026
d1675a1
Fix per dialyzer
paulo-ferraz-oliveira Mar 13, 2026
5e9eb02
Use release 5.0.1 of elvis_core
elbrujohalcon Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions config/elvis-test-pa.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,8 @@
[
{
elvis,
[
{config, [
#{
dirs => ["../../test/examples"],
filter => "user_defined_rules.erl",
rules => [{user_defined_rules, rule}]
}
]}
]
}
{config, [
#{
files => ["../../test/examples/user_defined_rules.erl"],
rules => [{user_defined_rules, rule}]
}
]}
].
27 changes: 10 additions & 17 deletions config/elvis-test.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,12 @@
[
{
elvis,
[
{config, [
#{
dirs => ["../../src"],
filter => "*.erl",
ruleset => erl_files
},
#{
dirs => ["../.."],
filter => "rebar.config",
ruleset => rebar_config
}
]}
]
}
{config, [
#{
files => ["../../src/*.erl"],
ruleset => erl_files
},
#{
files => ["../../rebar.config"],
ruleset => rebar_config
}
]}
].
18 changes: 6 additions & 12 deletions config/elvis.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,8 @@
[
{
elvis,
[
{config, [
#{
dirs => ["src"],
filter => "*.erl",
ruleset => erl_files
}
]}
]
}
{config, [
#{
files => ["src/*.erl"],
ruleset => erl_files
}
]}
].
9 changes: 9 additions & 0 deletions config/elvis2.config
View file
Open in desktop
Comment thread
paulo-ferraz-oliveira marked this conversation as resolved.
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
[
{config, [
#{
files => ["../../test/examples/**.erl"],
ruleset => erl_files
}
]},
{output_format, plain}
].
87 changes: 41 additions & 46 deletions config/old/elvis-test-rule-config-list.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,49 +1,44 @@
[
{
elvis,
[
{config, [
#{
dirs => ["../../test/examples"],
filter => "*.erl",
rules => [
{elvis_style, line_length, [80]},
{elvis_style, no_tabs, []},
{elvis_style, macro_names, []},
{elvis_style, operator_spaces, [
{right, ","},
{right, "++"},
{left, "++"}
]},
{elvis_style, nesting_level, [3]},
{elvis_style, god_modules, [25]},
{elvis_style, no_if_expression, []},
{elvis_style, invalid_dynamic_call, [elvis]},
{elvis_style, used_ignored_variable, []},
{elvis_style, no_behavior_info, []},
{
elvis_style,
module_naming_convention,
["^([a-z][a-z0-9]*_?)*(_SUITE)?$", []]
},
{elvis_style, state_record_and_type, []},
{elvis_style, no_spec_with_records, []}
]
{config, [
#{
dirs => ["../../test/examples"],
filter => "*.erl",
rules => [
{elvis_style, line_length, [80]},
{elvis_style, no_tabs, []},
{elvis_style, macro_names, []},
{elvis_style, operator_spaces, [
{right, ","},
{right, "++"},
{left, "++"}
]},
{elvis_style, nesting_level, [3]},
{elvis_style, god_modules, [25]},
{elvis_style, no_if_expression, []},
{elvis_style, invalid_dynamic_call, [elvis]},
{elvis_style, used_ignored_variable, []},
{elvis_style, no_behavior_info, []},
{
elvis_style,
module_naming_convention,
["^([a-z][a-z0-9]*_?)*(_SUITE)?$", []]
},
#{
dirs => ["."],
filter => "rebar.config",
rules => [
{elvis_project, no_deps_master_rebar, []},
{elvis_project, protocol_for_deps_rebar, []}
]
},
#{
dirs => ["."],
filter => "elvis.config",
rules => [{elvis_project, old_configuration_format, []}]
}
]}
]
}
{elvis_style, state_record_and_type, []},
{elvis_style, no_spec_with_records, []}
]
},
#{
dirs => ["."],
filter => "rebar.config",
rules => [
{elvis_project, no_deps_master_rebar, []},
{elvis_project, protocol_for_deps_rebar, []}
]
},
#{
dirs => ["."],
filter => "elvis.config",
rules => [{elvis_project, old_configuration_format, []}]
}
]}
].
55 changes: 25 additions & 30 deletions config/old/elvis-test.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,28 @@
[
{
elvis,
[
{config, #{
src_dirs => ["../../src"],
rules => [
{elvis_style, line_length, [80]},
{elvis_style, no_tabs, []},
{elvis_style, macro_names, []},
{elvis_style, operator_spaces, [
{right, ","},
{right, "++"},
{left, "++"}
]},
{elvis_style, nesting_level, [3]},
{elvis_style, god_modules, [25]},
{elvis_style, no_if_expression, []},
{elvis_style, invalid_dynamic_call, [elvis]},
{elvis_style, used_ignored_variable, []},
{elvis_style, no_behavior_info, []},
{
elvis_style,
module_naming_convention,
["^([a-z][a-z0-9]*_?)*(_SUITE)?$", []]
},
{elvis_style, state_record_and_type, []},
{elvis_style, no_spec_with_records, []}
]
}}
{config, #{
src_dirs => ["../../src"],
rules => [
{elvis_style, line_length, [80]},
{elvis_style, no_tabs, []},
{elvis_style, macro_names, []},
{elvis_style, operator_spaces, [
{right, ","},
{right, "++"},
{left, "++"}
]},
{elvis_style, nesting_level, [3]},
{elvis_style, god_modules, [25]},
{elvis_style, no_if_expression, []},
{elvis_style, invalid_dynamic_call, [elvis]},
{elvis_style, used_ignored_variable, []},
{elvis_style, no_behavior_info, []},
{
elvis_style,
module_naming_convention,
["^([a-z][a-z0-9]*_?)*(_SUITE)?$", []]
},
{elvis_style, state_record_and_type, []},
{elvis_style, no_spec_with_records, []}
]
}
}}
].
55 changes: 25 additions & 30 deletions config/old/elvis.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,28 @@
[
{
elvis,
[
{config, #{
src_dirs => ["src"],
rules => [
{elvis_style, line_length, [80]},
{elvis_style, no_tabs, []},
{elvis_style, macro_names, []},
{elvis_style, operator_spaces, [
{right, ","},
{right, "++"},
{left, "++"}
]},
{elvis_style, nesting_level, [3]},
{elvis_style, god_modules, [25]},
{elvis_style, no_if_expression, []},
{elvis_style, invalid_dynamic_call, [elvis]},
{elvis_style, used_ignored_variable, []},
{elvis_style, no_behavior_info, []},
{
elvis_style,
module_naming_convention,
["^([a-z][a-z0-9]*_?)*(_SUITE)?$", []]
},
{elvis_style, state_record_and_type, []},
{elvis_style, no_spec_with_records, []}
]
}}
{config, #{
src_dirs => ["src"],
rules => [
{elvis_style, line_length, [80]},
{elvis_style, no_tabs, []},
{elvis_style, macro_names, []},
{elvis_style, operator_spaces, [
{right, ","},
{right, "++"},
{left, "++"}
]},
{elvis_style, nesting_level, [3]},
{elvis_style, god_modules, [25]},
{elvis_style, no_if_expression, []},
{elvis_style, invalid_dynamic_call, [elvis]},
{elvis_style, used_ignored_variable, []},
{elvis_style, no_behavior_info, []},
{
elvis_style,
module_naming_convention,
["^([a-z][a-z0-9]*_?)*(_SUITE)?$", []]
},
{elvis_style, state_record_and_type, []},
{elvis_style, no_spec_with_records, []}
]
}
}}
].
22 changes: 9 additions & 13 deletions config/test.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,11 @@
[
{
elvis,
[
{config, [
#{
dirs => ["../../test/examples"],
filter => "**.erl",
ruleset => erl_files
}
]},
{output_format, plain}
]
}
{elvis, [
{config, [
#{
files => ["../../test/examples/**.erl"],
ruleset => erl_files
}
]},
{output_format, plain}
]}
].
43 changes: 19 additions & 24 deletions elvis.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,22 @@
[
{elvis, [
{config, [
#{
dirs => ["src"],
filter => "*.erl",
ruleset => erl_files_strict,
rules => [{elvis_style, max_function_length, #{max_length => 50}}]
},
#{
dirs => ["test"],
filter => "*.erl",
ruleset => erl_files_test
},
#{
dirs => ["."],
filter => "rebar.config",
ruleset => rebar_config
},
#{
dirs => ["."],
filter => ".gitignore",
ruleset => gitignore
}
]}
{config, [
#{
files => ["src/**/*.erl"],
ruleset => erl_files_strict,
rules => [{elvis_style, max_function_length, #{max_length => 50}}]
},
#{
files => ["test/**/*.erl"],
ruleset => erl_files_test,
rules => [{elvis_style, no_debug_call, disable}]
},
#{
files => ["rebar.config"],
ruleset => rebar_config
},
#{
files => [".gitignore"],
ruleset => gitignore
}
]}
].
5 changes: 3 additions & 2 deletions rebar.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
]}.

{alias, [
{go, [fmt, compile, hank, xref, dialyzer, {ct, "--verbose"}, {cover, "--verbose"}]},
{
test, [
{fmt, "--check --verbose"},
Expand All @@ -37,10 +38,10 @@

%% == Dependencies and plugins ==

{deps, [{elvis_core, "4.2.3"}, {getopt, "1.0.3"}]}.
{deps, [{elvis_core, "5.0.1"}, {getopt, "1.0.3"}]}.

{project_plugins, [
{rebar3_hank, "~> 1.4.1"},
{rebar3_hank, "~> 1.6.1"},
{rebar3_hex, "~> 7.0.11"},
{erlfmt, "~> 1.7.0"},
{rebar3_ex_doc, "~> 0.2.31"}
Expand Down
Loading
Loading