Adapt to elvis_core 5.x - #602
Merged
Merged
Conversation
elbrujohalcon
requested changes
Mar 12, 2026
Collaborator
Author
|
I tested this locally with the |
Collaborator
Author
|
When you wanna test this you'll need to update |
elbrujohalcon
approved these changes
Mar 13, 2026
elbrujohalcon
left a comment
elbrujohalcon
left a comment
Member
There was a problem hiding this comment.
Left some comments here and there, but I'm approving.
Collaborator
Author
|
When |
To use it, set --warnings_as_errors=false, or -e=false
The previous test was reading from elvis.config, inside config as a an application element (check deleted default_config()) Thing is this is inconsistent with elvis_core, that'll try to read elvis_core, in its namespace, which makes me be pretty sure this isn't being used in the wild!
Co-authored-by: Brujo Benavides <fernando_benavides_rodriguez@baxter.com>
paulo-ferraz-oliveira
force-pushed
the
fix/elvis_core-5.x
branch
from
March 13, 2026 23:10
4b678cd to
8ceff13
Compare
Collaborator
Author
|
Pushing a new |
Collaborator
Author
|
We got ✅ |
Member
|
https://hex.pm/packages/elvis_core/5.0.1 is done :) |
elbrujohalcon
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Didn't test this thoroughly, but trust CI.