Skip to content

[FCC] Update Drop Collections #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmcarcell merged 2 commits into from
Aug 4, 2026
Merged

[FCC] Update Drop Collections #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b0d45e
Add edm4hep::RecDqdx Colls to drop Colls
Victor-Schwan Apr 16, 2026
8f69a10
Drop all RecDqdxCollection by type and not individually
Victor-Schwan Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions StandardConfig/production/Calibration/Calibration_ILD_FCCee_v01.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,11 +97,11 @@ CONSTANTS = {
#
"AdditionalDropCollectionsREC": [
"BCAL",
"FTDCollection",
"BeamCalCollection",
"EcalEndcapsCollectionGapHits", # NOT EMPTY, encoding missing

@tmadlener tmadlener Aug 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remind me where the missing encoding string becomes a problem?

@Victor-Schwan Victor-Schwan Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might have been a hotfix for key4hep/k4MarlinWrapper#477. Not sure though

@tmadlener tmadlener Aug 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still possible to check that easily somehow? IIRC that failed in the event display, right? Might be as quick as removing this from being dropped and trying to run an event display(?).

@Victor-Schwan Victor-Schwan Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is also what I remember. The event display has obviously to be called via the k4MarlinWrapper ...

"FTDCollection",
"FTD_PIXELCollection",
"FTD_STRIPCollection",
"RelationBCalHit",
"FTDPixelTrackerHitRelations",
"FTDPixelTrackerHits",
"FTDSpacePointRelations",
Expand All @@ -111,14 +111,15 @@ CONSTANTS = {
"FTD_STRIPCollection",
"LHCalCollection",
"LHCAL",
"RelationBCalHit",
"RelationLHcalHit",
"SITCollection",
"SITTrackerHitRelations",
"SITTrackerHits",
"SiTracks",
"VXDCollection",
"VXDTrackerHitRelations",
"VXDTrackerHits"
"VXDTrackerHits",
]

}
2 changes: 2 additions & 0 deletions StandardConfig/production/ILDReconstruction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,6 +363,8 @@ def get_cms_energy_config(

output_commands = ["keep *"]
output_commands.extend(get_drop_collections(CONSTANTS, True))
# get_drop_collections incorrectly splits "type edm4hep::..." into two separate drops

@jmcarcell jmcarcell Aug 4, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe consider renaming get_drop_collections to something that includes calibration since they are there for calibration.

output_commands.append("drop type edm4hep::RecDqdxCollection")
io_handler.add_edm4hep_writer(
f"{reco_args.outputFileBase}_REC.edm4hep.root", output_commands
)
Expand Down
Loading