[FCC] Update Drop Collections - #190
Conversation
|
|
||
| output_commands = ["keep *"] | ||
| output_commands.extend(get_drop_collections(CONSTANTS, True)) | ||
| # get_drop_collections incorrectly splits "type edm4hep::..." into two separate drops |
There was a problem hiding this comment.
Maybe consider renaming get_drop_collections to something that includes calibration since they are there for calibration.
| "BCAL", | ||
| "FTDCollection", | ||
| "BeamCalCollection", | ||
| "EcalEndcapsCollectionGapHits", # NOT EMPTY, encoding missing |
There was a problem hiding this comment.
Can you remind me where the missing encoding string becomes a problem?
There was a problem hiding this comment.
Might have been a hotfix for key4hep/k4MarlinWrapper#477. Not sure though
There was a problem hiding this comment.
Is it still possible to check that easily somehow? IIRC that failed in the event display, right? Might be as quick as removing this from being dropped and trying to run an event display(?).
There was a problem hiding this comment.
That is also what I remember. The event display has obviously to be called via the k4MarlinWrapper ...
3 participants
BEGINRELEASENOTES
Calibration_ILD_FCCee_v01.cfgalphabeticallyRecDqdxCollectionbecause they cause the viewer to crashENDRELEASENOTES