Skip to content

Simplify collision handling - #179005

Merged
arturpragacz merged 3 commits into
devfrom
ap/h/device_registry/child-devices
Aug 13, 2026
Merged

Simplify collision handling#179005
arturpragacz merged 3 commits into
devfrom
ap/h/device_registry/child-devices

Conversation

@arturpragacz

Copy link
Copy Markdown
Member

Proposed change

Simplify collision handling for #178666.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Simplifies device-registry collision handling introduced for child devices in #178666.

Changes:

  • Always rejects main-device identifier collisions with child devices.
  • Rejects registrations spanning multiple child devices.
  • Updates collision tests for stale and connection-bearing devices.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
homeassistant/helpers/device_registry.py Simplifies and strengthens child-device collision validation.
tests/helpers/test_device_registry.py Updates and expands collision behavior coverage.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@emontnemery emontnemery left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some minor adjustments

Comment thread homeassistant/helpers/device_registry.py Outdated
Comment thread homeassistant/helpers/device_registry.py Outdated
Comment thread homeassistant/helpers/device_registry.py Outdated
Comment thread tests/helpers/test_device_registry.py Outdated
Comment thread tests/helpers/test_device_registry.py Outdated
Comment thread tests/helpers/test_device_registry.py Outdated
Comment thread tests/helpers/test_device_registry.py Outdated
Comment thread tests/helpers/test_device_registry.py Outdated
Copilot AI review requested due to automatic review settings August 13, 2026 09:40

@emontnemery emontnemery left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice cleanup 👍

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings August 13, 2026 09:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@MartinHjelmare

Copy link
Copy Markdown
Member

I don't think we want to merge the Add child devices PR implicitly. Stacked PRs working like this doesn't seem wanted.

@MartinHjelmare
MartinHjelmare marked this pull request as draft August 13, 2026 10:20
Comment thread homeassistant/helpers/device_registry.py
Comment thread homeassistant/helpers/device_registry.py
Copilot AI review requested due to automatic review settings August 13, 2026 10:58
@emontnemery
emontnemery marked this pull request as ready for review August 13, 2026 10:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

arturpragacz and others added 3 commits August 13, 2026 13:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@MartinHjelmare MartinHjelmare left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants