Skip to content

Reapply comment in async_get_or_create in device registry - #179076

Merged
MartinHjelmare merged 1 commit into
devfrom
ap/h/device_registry/reapply-get-or-create-comment
Aug 13, 2026
Merged

Reapply comment in async_get_or_create in device registry#179076
MartinHjelmare merged 1 commit into
devfrom
ap/h/device_registry/reapply-get-or-create-comment

Conversation

@arturpragacz

Copy link
Copy Markdown
Member

Proposed change

Reapply comment in async_get_or_create in device registry.

Was supposed to be in #179005 (comment), but somehow was not? Not sure what happened there.

@MartinHjelmare

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • I understand the code I am submitting and can explain how it works.
  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.
  • Any generated code has been carefully reviewed for correctness and compliance with project standards.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies a diff between library versions and ideally a link to the changelog/release notes is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI balanced review requested due to automatic review settings August 13, 2026 14:05
@arturpragacz
arturpragacz requested a review from a team as a code owner August 13, 2026 14:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Restores the intended explanatory comment in device registry collision handling.

Changes:

  • Clarifies why parentless devices cannot reuse child identifiers.
  • No functional code changes.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@MartinHjelmare MartinHjelmare left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare
MartinHjelmare merged commit 82807d1 into dev Aug 13, 2026
49 checks passed
@MartinHjelmare
MartinHjelmare deleted the ap/h/device_registry/reapply-get-or-create-comment branch August 13, 2026 21:17
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants