Address opam archive review: rename, drop ocaml dep, fix maintainer - #542
Merged
Conversation
Review on rocq-prover/opam#3829 (proux01, "a few comments but otherwise LGTM"). Three of the four are fixed here; the fourth was declined with a reason. 1. RENAME rocq-robust-predicates -> rocq-robust-geometric-predicates. "robust-predicates seems a bit overly generic" and "geometric seems like a very important keyword". Agreed: the discriminating word was only in the synopsis. Renaming is free right now and impossible after the archive entry merges. The directory, opam file, workflow, MANIFEST, dune stanzas, nix pname and release script all move together; theories/dune (package ...) must match the opam filename or dune fails, so a partial rename would have broken the build rather than passing quietly. 2. DROP the "ocaml" dependency, both packages. "Does this really need ocaml? I don't see any ml code in the tarball." Verified: zero .ml/.mli/.mll/.mly in either tarball, and the Makefile's only ocaml/dune mentions are a tar file list and a comment. The build is pure `rocq makefile`. I had copied this from rocq-bignums, which genuinely ships OCaml -- we do not, so it was an unearned dependency. 3. FIX maintainer, both packages: was an issue-tracker URL, now a person. The opam field means the maintainer of the package, not where to file bugs; bug-reports already carries the tracker URL. 4. DECLINED: mentioning JTS in the description. The package is standalone Rocq with no JTS dependency, and a Rocq user installing it needs nothing about Java geometry libraries. homepage already leads anyone curious to the corpus. Also trimmed the long coq-flocq rationale in the repo copy to the three-line version already submitted upstream, so the two no longer diverge. Verified after the rename: 21 files assemble, make clean, opam lint Passed. topics: packaging, opam witness: assemble + make + opam lint clean under the new name claimId: n/a (packaging)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review on rocq-prover/opam#3829 from proux01 — "A few comments but otherwise LGTM." Three fixed, one declined with a reason.
1. Rename →
rocq-robust-geometric-predicatesAgreed — the discriminating word was only in the synopsis. Free now, impossible after the archive entry merges. Directory, opam file, workflow, MANIFEST, dune stanzas, nix
pnameand release script all move together;theories/dune's(package ...)must match the opam filename or dune fails, so a partial rename would break the build rather than pass quietly.2. Drop the
ocamldependency (both packages)He's right, and I verified it: zero
.ml/.mli/.mll/.mlyfiles in either tarball, and the Makefile's onlyocaml/dunementions are atarfile list and a comment. The build is purerocq makefile. I had copied this fromrocq-bignums, which genuinely ships OCaml — we don't, so it was an unearned dependency.3. Fix
maintainer(both packages)Was an issue-tracker URL, now a person.
bug-reportsalready carries the tracker URL.4. Declined — mentioning JTS in the description
The package is standalone Rocq with no JTS dependency, and a Rocq user installing it needs nothing about Java geometry libraries.
homepagealready leads anyone curious to the corpus. Recorded here so the decision is visible rather than silently skipped.Also
Trimmed the long
coq-flocqrationale in the repo copy to the three-line version already submitted upstream, so the two no longer diverge.Verified
21 files assemble,
makeclean,opam lintPassed under the new name.Next, after this merges
rocq-robust-predicates 0.1.0is already published with a tarball whose internal opam file carries the old name. Rather than point the renamed archive entry at a mismatched tarball, I'll cutrocq-robust-geometric-predicates-v0.1.0and update #3829 with the new URL and checksum.rocq-spatial-algebra 0.1.0is unaffected — its tarball and archive entry stand as published, and only itsmaintainer/ocamllines change.topics: packaging, opam
witness: assemble + make + opam lint clean under the new name
claimId: n/a (packaging)