Add the geometric keywords the rename implied - #543
Merged
Conversation
The review asked for "geometric" in the name, and the package was renamed -- but the keyword list itself was never updated, so a search for "geometric" still would not surface it. The name is not indexed as a keyword; the tags are. Adds "keyword:geometric" and "keyword:geometric predicates" alongside the existing "computational geometry", which was the only geometry term present and is a narrower field name rather than a match for the thing itself. rocq-spatial-algebra deliberately unchanged: DE-9IM spatial relations are a GIS vocabulary, and its keywords already say so. topics: packaging, opam witness: opam lint clean claimId: n/a (metadata)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The archive review asked for
geometricin the name, and #542 renamed thepackage — but the keyword list was never updated, so a search for
"geometric" still would not surface it. The package name is not indexed as a
keyword; the tags are.
computational geometrywas the only geometry term present, and that is a fieldname rather than a match for the thing itself.
rocq-spatial-algebradeliberately unchanged — its subject is DE-9IMspatial relations, a GIS vocabulary, and its keywords already say
DE-9IM,spatial relations,GIS,intersection matrix. Adding "geometric" therewould broaden it toward a term that does not describe what it does.
The archive entry on rocq-prover/opam#3829
already carries this, so upstream is correct either way — this keeps the repo
from silently reverting it on the next release cut from
main.No re-cut of the tarball: opam resolves metadata from the archive's opam file,
not the copy inside the tarball, so a keyword divergence there is invisible.
topics: packaging, opam
witness: opam lint clean
claimId: n/a (metadata)