Skip to content

Use gz-rotary-sdformat in macos workflow - #1694

Merged
scpeters merged 2 commits into
mainfrom
scpeters/fix_package_name_in_macos_workflow
Aug 9, 2026
Merged

Use gz-rotary-sdformat in macos workflow#1694
scpeters merged 2 commits into
mainfrom
scpeters/fix_package_name_in_macos_workflow

Conversation

@scpeters

@scpeters scpeters commented Aug 8, 2026

Copy link
Copy Markdown
Member

🦟 Bug fix

Fixes incorrect dependency versions in macos workflow

Summary

The macos workflow has started failing recently for pull requests targeting the main branch (see #1691 and #1693).

The macos workflow currently uses a hardcoded PACKAGE variable to encode the homebrew formula name whose dependencies should be installed. The main branch is still using the Jetty formula sdformat16, so this should be updated to gz-rotary-sdformat, which also avoids needing to specify the number.

Backport Policy

  • This is safe to backport to the following versions:
    • Jetty
    • Ionic
    • Harmonic
    • Fortress
  • This should not be backported
  • I am not sure
  • Other (fill in yourself)

Checklist

  • Signed all commits for DCO
  • Added a screen capture or video to the PR description that demonstrates the fix (as needed)
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • Updated Bazel files (if adding new files). Created an issue otherwise.
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Assisted-by" to your commits. (See this policy for more info.)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Backports: If this is a backport, please use Rebase and Merge instead.

Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
Signed-off-by: Steve Peters <scpeters@intrinsic.ai>
@scpeters
scpeters marked this pull request as ready for review August 9, 2026 01:08
@scpeters
scpeters requested a review from azeey as a code owner August 9, 2026 01:08
@scpeters
scpeters requested review from iche033 and j-rivero August 9, 2026 01:09
@github-project-automation github-project-automation Bot moved this from Inbox to In review in Core development Aug 9, 2026
@scpeters
scpeters merged commit fdd1b58 into main Aug 9, 2026
17 checks passed
@scpeters
scpeters deleted the scpeters/fix_package_name_in_macos_workflow branch August 9, 2026 10:47
@github-project-automation github-project-automation Bot moved this from In review to Done in Core development Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants