Add FeatureState as the persistence boundary - #180
Open
michal-granec wants to merge 3 commits into
Open
Conversation
Introduce a backend-neutral feature snapshot and move Redis encode/decode out of Feature so later adapters can share the same evaluation path. Pin CRC32, payload, mutation, and history behavior with characterization tests.
Copy normalized name, user, and group strings so snapshots do not alias the source feature. Restore symbol names on Feature while FeatureState keeps string names for persistence. Reject non-Hash metadata and rely on FeatureState defaults when clearing.
5 tasks
Keep the caller's String or Symbol feature name at the public Feature boundary, and reject unsupported metadata values instead of sharing them across snapshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rollout::FeatureStateas the backend-neutral snapshot of feature configuration.Rollout::RedisCodecand constructFeatureonly fromFeatureState.This is the first Rollout 3 slice. It does not extract
rollout-redis, add Active Record, change hashing, or raise the Ruby requirement.Test plan
with_featurestill saves one combined mutation and records one history eventdeleteremoves feature history;clear!keeps it