Extract rollout-redis as a separate adapter gem - #181
Open
michal-granec wants to merge 5 commits into
Open
Conversation
3 tasks
Move Redis persistence and history into Rollout::Redis::Backend. Core Rollout takes a backend and no longer depends on redis.
setup-ruby should install rollout-redis/Gemfile from that directory so BUNDLE_GEMFILE is unnecessary and bundle exec rspec finds the gems.
Bump core to 3.0.0, require a compatible core range in the adapter, and keep logging/observer snapshot eligibility consistent through a mutation.
michal-granec
force-pushed
the
v3-redis-backend
branch
from
September 9, 2026 13:39
6ea71cc to
a8328e7
Compare
Read only the requested history entries, decode Redis events in the adapter, and give the backend a clear_features hook so clear! can remove the empty registry without changing logging-disabled delete behavior.
The shared examples live in the repository spec/support directory, two levels above the adapter specs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #180.
Summary
rollout-redis(Rollout::Redis::Backend+Rollout::Redis::Codec).Rolloutnow takesbackend:and no longer depends on redis.rollout-redis/spec.This is the second Rollout 3 slice. It does not add Active Record, change hashing, or raise the Ruby requirement.
Test plan
Rollout.new(backend: Rollout::Redis::Backend.new(redis))activates, deactivates, and evaluates as beforehistory_length;deleteremoves feature history;clear!keeps itChecks: core 20 examples passed, Redis adapter 103 examples passed, rebased onto
v3-feature-state.