Skip to content

igl | vulkan | Normalize renderPassIndex so that format-compatible render passes (same formats/samples, different load/store/layout) share one PSO. #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vinsentli wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −0
Open

igl | vulkan | Normalize renderPassIndex so that format-compatible render passes (same formats/samples, different load/store/layout) share one PSO. #429

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0f33a7
对 renderPassIndex 进行归一化处理，使格式兼容的渲染通道
vinsentli Aug 10, 2026
a22aef4
删除RenderPipelineDynamicState.renderPassIndex字段。
vinsentli Aug 11, 2026
8f4b510
Revert "删除RenderPipelineDynamicState.renderPassIndex字段。"
vinsentli Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/igl/vulkan/RenderPipelineState.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,15 @@ VkPipeline RenderPipelineState::getVkPipeline(
cacheKey.depthBiasEnable = 0;
}

// Normalize renderPassIndex so that format-compatible render passes
// (same formats/samples, different load/store/layout) share one PSO.
// Per Vulkan spec:https://docs.vulkan.org/spec/latest/chapters/renderpass.html#renderpass-compatibility
// render pass compatibility only depends on format, samples,
// and flags -- NOT on loadOp/storeOp/initialLayout/finalLayout.
// This is safe because desc_.targetDesc already pins the format expectations
// for this RenderPipelineState, so all render passes it encounters are compatible.
cacheKey.renderPassIndex = 0;

const auto it = pipelines_.find(cacheKey);

if (it != pipelines_.end()) {
Expand Down
Loading