igl | vulkan | Remove RenderPipelineDynamicState.renderPassIndex so that format-compatible render passes (same formats/samples, different load/store/layout) share one PSO. - #429
Open
vinsentli wants to merge 2 commits into
Conversation
| // and flags -- NOT on loadOp/storeOp/initialLayout/finalLayout. | ||
| // This is safe because desc_.targetDesc already pins the format expectations | ||
| // for this RenderPipelineState, so all render passes it encounters are compatible. | ||
| cacheKey.renderPassIndex = 0; |
Contributor
There was a problem hiding this comment.
Can it be removed completely?
# Conflicts: # src/igl/vulkan/RenderPipelineState.h
vinsentli
changed the title
vinsentli
changed the title
corporateshark
requested changes
Aug 11, 2026
corporateshark
left a comment
corporateshark
left a comment
Contributor
There was a problem hiding this comment.
This makes the whole change much more convoluted. Let's fall back to the original approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove renderPassIndex so that format-compatible render passes(same formats/samples, different load/store/layout) share one PSO.
Per Vulkan spec:https://docs.vulkan.org/spec/latest/chapters/renderpass.html#renderpass-compatibility
Render pass compatibility only depends on format, samples,and flags -- NOT on loadOp/storeOp/initialLayout/finalLayout.
This is safe because desc_.targetDesc already pins the format expectations for this RenderPipelineState, so all render passes it encounters are compatible.