Conversation
xfocus3
force-pushed
the
fix/icons-auto-piped-columns
branch
from
October 1, 2026 13:18
a3e83b2 to
f057a47
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COLUMNSand--widthas layout inputs, so piped output can still use a grid while--icons=autosuppresses iconsThe git2 dependency and API updates from earlier commits are now already on main. The product change is limited to
src/options/view.rs; two existing version snapshots are also refreshed to match the current package version, 0.23.5.Fixes #1842.
Validation
cargo fmt --checkcargo test --locked deduce_view_keeps_terminal_state_separate --libcargo test --locked --workspacecargo test --locked --workspace --no-default-featurescargo clippy --locked --workspace --all-targets -- -D warningscargo build --lockedCOLUMNS,--width, automatic width, and--icons=auto/always/never; repeated with default features and without default featuresCOLUMNSand--width, then verified the refreshed branch fixes bothThe extra no-default-features Clippy check reports an existing
needless_returninsrc/main.rs, also reproduced on unchanged main. That unrelated code is unchanged. MSRV, other-platform, and Nix-specific checks were not run locally; they passed in CI.All 32 CI checks passed on
a75998d: completed workflow run.