Repository navigation
feat: port --since filter, -S/--blocks flag, icons terminal isolation, and newest sort aliases (eza#1687, #1667, #1849, #1853) - #18
Merged
Conversation
fxrdhan
force-pushed
the
feat/upstream-ports-pr18
branch
from
August 21, 2026 05:26
696f0e1 to
eb43890
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR ports and hardens four high-priority upstream features and bugfixes from eza-community/eza into
lsr. Each item is committed as its own granular, atomic commit:Commit 1 (
452680ff):feat(filter): implement --since time-based file filtering flag(ported from eza-community/eza#1687)--since <DURATION>CLI flag to filter and display only files created or modified within the specified duration window (e.g.10m,1h,2d,1w).humantimefor robust human-friendly duration parsing and checks both modified and created timestamps against current time cutoff.README.md,man/eza.1.md,man/lsr.1.md) and shell completions (bash,zsh,fish,nushell,powershell).src/options/filter.rs,tests/since_flag_tests.rs, andtests/adversarial_since_m1_challenger_tests.rs.Commit 2 (
5d1b6c12):feat(view): add -S / --blocks flag for filesystem block counts(ported from eza-community/eza#1667)-S/--blocksCLI flag (as an alias to--blocksize) to toggle displaying 512-byte allocated filesystem block counts in long table view (-l).-S/--blocksis passed without--longand full parity across short and long flag invocations.tests/blocks_flag_tests.rs,tests/adversarial_blocks_m2_challenger_tests.rs, andtests/adversarial_blocks_m2_challenger2_full_tests.rs.Commit 3 (
0d918599):fix(view): decouple icons=auto terminal detection from COLUMNS(ported from eza-community/eza#1849 and eza-community/eza#1843)--icons=autoterminal detection from terminal-width deduction, queryingvars.stdout_is_terminal()directly.COLUMNSenvironment variable from erroneously enabling Nerd Font icons in non-interactive pipes or file redirects.src/options/view.rsand integration tests intests/icons_auto_terminal_tests.rs.Commit 4 (
eb438909):fix(sort): align sort aliases so newest/new sorts newest-first(ported from eza-community/eza#1853)--sort=newestand--sort=newmap toSortField::ModifiedAge(sorting newest files at the top, matching--sort=age), whileoldandoldestmap toSortField::ModifiedDate(sorting oldest files at the top).README.md,man/eza.1.md,man/lsr.1.md) and shell completions (bash,zsh,fish,pwsh).src/options/filter.rsand dedicated integration tests intests/sort_aliases_tests.rs.How Has This Been Tested?
cargo test --all-targets(all unit and integration tests passing across all test suites, includingtests/since_flag_tests.rs,tests/adversarial_since_m1_challenger_tests.rs,tests/blocks_flag_tests.rs,tests/icons_auto_terminal_tests.rs, andtests/sort_aliases_tests.rs).cargo clippy --all-targets --all-features -- -D warnings(0 warnings).cargo fmt --all -- --check(clean).reuse lint(100% compliant with REUSE v3.3 specification across 561 files).