Skip to content

fix: allow page margin properties in @page rules - #143

Merged
DMartens merged 1 commit into
mainfrom
fix/page-margin-properties
Aug 4, 2026
Merged

fix: allow page margin properties in @page rules#143
DMartens merged 1 commit into
mainfrom
fix/page-margin-properties

Conversation

@Pixel998

@Pixel998 Pixel998 commented Aug 4, 2026

Copy link
Copy Markdown

Prerequisites checklist

AI acknowledgment

  • I did not use AI to generate this PR.
  • (If the above is not checked) I have reviewed the AI-generated content before submitting.

What is the purpose of this pull request?

Allow valid page-margin declarations in @page rules.

What changes did you make? (Give an overview)

Added margin and the four physical margin longhands to the @page syntax-data patch.

Related Issues

Refs eslint/css#519

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot Bot added the bug Something isn't working label Aug 4, 2026
@eslintbot eslintbot added this to Triage Aug 4, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Triage Aug 4, 2026
@Pixel998 Pixel998 moved this from Needs Triage to Implementing in Triage Aug 4, 2026

@DMartens DMartens left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks.

@DMartens
DMartens merged commit 9cb5ec4 into main Aug 4, 2026
22 checks passed
@DMartens
DMartens deleted the fix/page-margin-properties branch August 4, 2026 21:58
@github-project-automation github-project-automation Bot moved this from Implementing to Complete in Triage Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants