-
Notifications
You must be signed in to change notification settings - Fork 61
fix: update material map validation script to Acts v46.8.1 #1159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+237
−85
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
9e45c42
fix: update material map validation script to Acts v46.8.1
wdconinc 7fab55c
fix: update runMaterialRecording call for Acts v46.8.1 API
wdconinc c225cad
fix: update material validation and mapping scripts for Acts v46.8.1 API
wdconinc d02529b
fix: handle --help flag in run_material_map_validation.sh
wdconinc e9202ac
fix: ignore plots
wdconinc 5334cd3
fix: indentation
wdconinc d5eff65
Fix Acts v46.8.1 API compatibility and CBOR removal
wdconinc fc44171
fix: re-enable material mapping plots
wdconinc 6e0df2a
fix: typo
wdconinc c6d44a6
fix: add quotes to allow shell variable expansion
wdconinc 9bdf328
Fix geometry JSON schema compatibility for Acts v46.8.1 visualization
wdconinc 237f2a5
fix: upload cbor and json material maps
wdconinc aa7a6b0
fix: restore cbor support; use upstream patches
wdconinc fc3e46b
fix: warn if no material map loaded
wdconinc 1482964
fix: ignore *.diff and *.cbor
wdconinc fa353cc
fix: upload any cbor, json and root files
wdconinc c304a34
fix: ok, save a bit less to the artifact (was 26 GB)
wdconinc 6760662
fix: upload only material_map-map.*
wdconinc 3ad3398
Change material validation to use matMapFile
wdconinc 8639f6f
Refactor material map parameter interface to use --matFileBase and --…
wdconinc 7101fbd
Add --prefix and --suffix command-line arguments to run_material_map_…
wdconinc 6354cf5
fix: rm patch that is now gotten from url
wdconinc f793e8f
Support prefix/suffix in geometry generation and configuration files
wdconinc ae2079f
Fix: pass --inputRootFile argument to material_mapping_epic.py
wdconinc 07c0be6
ci: add material map validation plots to GitHub Pages (#1167)
wdconinc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,4 +2,7 @@ Examples/ | |
| Surfaces/ | ||
| Validation/ | ||
| calibrations/ | ||
| plots/ | ||
| *.diff | ||
| *.cbor | ||
| *.json | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.