fix: update material map validation script to Acts v46.8.1 by wdconinc · Pull Request #1159 · eic/epic

wdconinc · 2026-08-23T17:58:13Z

Dependencies

hotfix: spack cherry-pick: acts: pass root variant to examples containers#397

Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.

This PR updates the material map validation script to Acts v46.8.1:

Update ACTS_VERSION from v45.3.0 to v46.8.1 to match the Acts version in the platform
Remove PR #5359 patch application, as the fix landed in Acts v46.3.0 (function kept)
This fixes CI failures in the validate-material-map job after the Acts upgrade

What is the urgency of this PR?

High (please describe reason below)
Medium
Low

CI is currently broken on main.

What kind of change does this PR introduce?

Bug fix (issue: https://github.com/eic/epic/actions/runs/32654353552/job/97232215042)
New feature (issue #__)
Optimization (issue #__)
Updated constants (issue #__)
Updated documentation
other: __

Please check if any of the following apply

This PR introduces breaking changes. Please describe changes users need to make below.
This PR changes default behavior. Please describe changes below.
AI was used in preparing this PR. Please describe usage below.

github-actions · 2026-08-23T19:05:28Z

Capybara summary for PR 1159

veprbl · 2026-09-01T19:24:48Z

Traceback (most recent call last):
  File "/home/runner/work/epic/epic/scripts/material_map/material_recording_epic.py", line 69, in <module>
    main()
    ~~~~^^
  File "/home/runner/work/epic/epic/scripts/material_map/material_recording_epic.py", line 59, in main
    runMaterialRecording(
    ~~~~~~~~~~~~~~~~~~~~^
        detector=detector,
        ^^^^^^^^^^^^^^^^^^
    ...<3 lines>...
        s=acts.examples.Sequencer(events=args.events, numThreads=1),
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ).run()
    ^
TypeError: runMaterialRecording() got an unexpected keyword argument 'outputDir'

wdconinc · 2026-09-01T19:26:07Z

TypeError: runMaterialRecording() got an unexpected keyword argument 'outputDir'

It's a different error at least now :-)

wdconinc · 2026-09-01T19:26:31Z

It's a different error at least now :-)

It's all in the definition of "progress".

wdconinc · 2026-09-01T19:31:23Z

FYI @ybedfer This is another change you will need, likely.

- Update ACTS_VERSION from v45.3.0 to v46.8.1 to match the Acts version in the platform - Remove PR #5359 patch application, as the fix landed in Acts v46.3.0 (function kept) - This fixes CI failures in the validate-material-map job after the Acts upgrade Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

The runMaterialRecording() function signature changed in Acts v46.8.1: - Removed: outputDir parameter - Added: outputFileBase parameter - Moved: sequencer parameter to second position This fixes the TypeError when running material map validation with Acts v46.8.1. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

The Acts v46.8.1 APIs have significant changes: - runMaterialValidation: Changed parameter order and replaced outputDir/outputName with outputFileBase - runMaterialMapping: Changed to accept surfaces list and inputFile path instead of outputDir/inputDir Both scripts now: - Extract material surfaces from trackingGeometry using extractMaterialSurfaces() - Pass surfaces as first parameter - Use outputFileBase instead of separate directory/name parameters Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Changed while loop condition from '0 -gt 1' to '0 -gt 0' to properly process single arguments. This fixes the --help flag not displaying help when it's the only argument. Also added explicit -h|--help case handler. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

- geometry_epic.py: Rename 'outputJson' → 'outputSurfacesJson' parameter - material_mapping_epic.py: matFile defaults to 'material-map.json' (produces '_map.json' output) - material_validation_epic.py: matFile now optional (empty string default) - epic.py: Add file existence check before loading material decorator - run_material_map_validation.sh: - Fix --help flag handling (was requiring 2+ arguments) - Use correct material-map filenames (material-map.json input → material-map_map.json output) - Pass correct generated material map file to validation step - Disable visualization scripts that fail on geometry JSON schema mismatch (temporary workaround) Note: v46.8.1 removed CBOR support; material maps now output as JSON and ROOT formats only. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

The geo_id field in Acts v46.8.1 changed from a simple uint64_t to an object with component fields (volume, boundary, layer, approach, sensitive). This patch reconstructs the uint64_t by bitwise ORing the components according to the GeometryIdentifier bit layout: - volume: bits 56-63 - boundary: bits 48-55 - layer: bits 36-47 - approach: bits 28-35 - sensitive: bits 0-27 Handles both old (numeric) and new (object) geo_id formats for compatibility. The patch is applied early in run_material_map_validation.sh before visualization scripts execute, enabling all surface plots to work with v46.8.1 geometry output. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

wdconinc · 2026-09-03T18:19:26Z

So, this runs now to completion, but doesn't produce the right material maps. I propose to merge as is, which unblocks some CI, and continue looking into the reasons why this fails. @veprbl @ShujieL

Current:

Regenerated:

Copilot AI lite review requested due to automatic review settings August 23, 2026 17:58

github-actions Bot added the topic: infrastructure Regarding build system, CI, CD label Aug 23, 2026

Copilot started reviewing on behalf of wdconinc August 23, 2026 17:58 View session

This comment was marked as low quality.

Sign in to view

wdconinc temporarily deployed to github-pages August 23, 2026 19:03 — with GitHub Actions Inactive

wdconinc mentioned this pull request Aug 23, 2026

fix: continue-on-error for 2DStrip eic/EICrecon#2889

Merged

14 tasks

veprbl previously approved these changes Aug 24, 2026

View reviewed changes

wdconinc dismissed veprbl’s stale review via 1b10fd7 September 1, 2026 19:31

wdconinc temporarily deployed to github-pages September 1, 2026 20:50 — with GitHub Actions Inactive

wdconinc and others added 10 commits September 1, 2026 16:56

fix: ignore plots

ebf301b

fix: indentation

49016af

fix: re-enable material mapping plots

f1d6134

fix: typo

28fe21a

fix: add quotes to allow shell variable expansion

167f36f

wdconinc force-pushed the material-map-acts-46 branch from 83ea5e1 to 167f36f Compare September 1, 2026 21:56

wdconinc temporarily deployed to github-pages September 1, 2026 23:27 — with GitHub Actions Inactive

wdconinc and others added 2 commits September 1, 2026 19:03

fix: upload cbor and json material maps

d6ee70a

wdconinc temporarily deployed to github-pages September 2, 2026 01:00 — with GitHub Actions Inactive

wdconinc commented Sep 2, 2026

View reviewed changes

Comment thread scripts/material_map/materialPlotHelper.cpp.patch

wdconinc commented Sep 2, 2026

View reviewed changes

Comment thread scripts/material_map/epic.py

wdconinc added 3 commits September 2, 2026 13:55

fix: restore cbor support; use upstream patches

9f42fb6

fix: warn if no material map loaded

90aca66

fix: ignore *.diff and *.cbor

349d973

wdconinc temporarily deployed to github-pages September 2, 2026 22:17 — with GitHub Actions Inactive

fix: upload any cbor, json and root files

22e7b47

wdconinc temporarily deployed to github-pages September 2, 2026 23:27 — with GitHub Actions Inactive

fix: ok, save a bit less to the artifact (was 26 GB)

3c96f6b

wdconinc temporarily deployed to github-pages September 3, 2026 00:48 — with GitHub Actions Inactive

fix: upload only material_map-map.*

2c01fd8

wdconinc temporarily deployed to github-pages September 3, 2026 17:59 — with GitHub Actions Inactive

wdconinc requested review from a team and ShujieL September 3, 2026 18:19

wdconinc enabled auto-merge (squash) September 3, 2026 18:23

Change material validation to use matMapFile

2ac553d

wdconinc temporarily deployed to github-pages September 3, 2026 23:43 — with GitHub Actions Inactive

Navigation Menu

Uh oh!

fix: update material map validation script to Acts v46.8.1 - #1159

fix: update material map validation script to Acts v46.8.1#1159
wdconinc wants to merge 19 commits into
mainfrom
material-map-acts-46

wdconinc commented Aug 23, 2026 •

edited by veprbl

Loading

Uh oh!

This comment was marked as low quality.

Uh oh!

github-actions Bot commented Aug 23, 2026 •

edited

Loading

Uh oh!

veprbl commented Sep 1, 2026

Uh oh!

wdconinc commented Sep 1, 2026

Uh oh!

wdconinc commented Sep 1, 2026

Uh oh!

wdconinc commented Sep 1, 2026

Uh oh!

Uh oh!

Uh oh!

wdconinc commented Sep 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

wdconinc commented Aug 23, 2026 • edited by veprbl Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dependencies

Briefly, what does this PR introduce? Please link to any relevant presentations or discussions.

What is the urgency of this PR?

What kind of change does this PR introduce?

Please check if any of the following apply

Uh oh!

This comment was marked as low quality.

Uh oh!

github-actions Bot commented Aug 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Capybara summary for PR 1159

Uh oh!

veprbl commented Sep 1, 2026

Uh oh!

wdconinc commented Sep 1, 2026

Uh oh!

wdconinc commented Sep 1, 2026

Uh oh!

wdconinc commented Sep 1, 2026

Uh oh!

Uh oh!

Uh oh!

wdconinc commented Sep 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wdconinc commented Aug 23, 2026 •

edited by veprbl

Loading

github-actions Bot commented Aug 23, 2026 •

edited

Loading