fix: remove *Associations from PODIO output collections by wdconinc · Pull Request #2822 · eic/EICrecon

wdconinc · 2026-08-03T20:20:30Z

Dependencies

fix(pid): DRICH IRT link migration #2875

Description

Removes 60 unused *Associations entries from the default output collections list in JEventProcessorPODIO.cc. These association collections are no longer needed in the standard PODIO output, reducing file size and output verbosity. For each of the removed *Associations, the *Links are written.

Also, modifies IrtCherenkovParticleID algorithm/factory to use links instead of associations to avoid dangling references.

Changes

Removed all *Associations collection entries from output_collections vector
Adds *Links collection outputs to IrtCherenkovParticleID algorithm/factory

This change affects the default PODIO output files generated by EICrecon, excluding these association collections unless explicitly requested via configuration.

Impact

Smaller output ROOT files by default
Faster file I/O operations
Users can still enable specific associations via podio:output_collections parameter if needed

Copilot

🟡 Not ready to approve

The implementation and PR description are inconsistent about which *Associations collections are still kept by default, and this needs to be clarified or corrected.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Pull request overview

This PR trims the default PODIO output collection include-list in JEventProcessorPODIO.cc by removing many *Associations collections (while keeping the corresponding *Links collections), aiming to reduce default output size and verbosity.

Changes:

Removed numerous *Associations entries from the default output_collections list.
Kept *Links entries alongside the corresponding reconstructed objects.
Left MCScatteredElectronAssociations / MCNonScatteredElectronAssociations (and also ReconstructedChargedParticleAssociations) in the default list.

File summaries

File	Description
src/services/io/podio/JEventProcessorPODIO.cc	Removes many `*Associations` collections from the default PODIO output collection list to reduce persisted output volume.

Review details

Suppressed comments (1)

src/services/io/podio/JEventProcessorPODIO.cc:216

The PR description says all *Associations entries were removed except the two MC*ElectronAssociations, but ReconstructedChargedParticleAssociations is still in the default output list. Either update the PR description to reflect this exception, or remove this entry if it is also intended to be excluded by default.

      "ReconstructedChargedParticles",
      "ReconstructedChargedParticleLinks",
      "ReconstructedChargedParticleAssociations",
      "MCScatteredElectronAssociations",    // Remove if/when used internally
      "MCNonScatteredElectronAssociations", // Remove if/when used internally

Files reviewed: 1/1 changed files
Comments generated: 0
Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

…s (fix: iwyu) (#2825) This PR applies the include-what-you-use fixes as suggested by https://github.com/eic/EICrecon/actions/runs/30852065609. Please merge this PR into the branch `wdconinc-fluffy-invention` to resolve failures in PR #2822. Auto-generated by [create-pull-request][1] [1]: https://github.com/peter-evans/create-pull-request Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Copilot

🟢 Ready to approve

The changes are focused and consistent with the stated goal, with only a minor wording clarification suggested in an inline comment.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Review details

Suppressed comments (1)

src/services/io/podio/JEventProcessorPODIO.cc:217

The inline comments for the temporary MC*Electron{Links,Associations} entries read "Remove if/when used internally", which is ambiguous and appears inverted (if they are used internally, they should not be removed). Reword to clarify they can be removed once they are no longer needed internally / after migration.

      "MCScatteredElectronLinks",           // Remove if/when used internally
      "MCScatteredElectronAssociations",    // Remove if/when used internally
      "MCNonScatteredElectronLinks",        // Remove if/when used internally
      "MCNonScatteredElectronAssociations", // Remove if/when used internally

Files reviewed: 2/2 changed files
Comments generated: 0 new
Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

Copilot

🟡 Not ready to approve

The default output now writes subset MC*ElectronAssociations collections without writing their parent ReconstructedChargedParticleAssociations, which can produce dangling collectionID references in the output.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.

Review details

Suppressed comments (1)

src/global/reco/reco.cc:17

The new #include <podio/detail/Link.h> and #include <deque> are unused in this translation unit, increasing compile time and risking unused-include warnings under stricter builds/clang-tidy.

#include <edm4hep/MCParticle.h>
#include <podio/detail/Link.h>
#include <deque>
#include <map>

Files reviewed: 6/6 changed files
Comments generated: 1
Review effort level: Lite

We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.

Removed 'ReconstructedChargedParticleAssociations' from the list.

…s (fix: iwyu) (#2825) This PR applies the include-what-you-use fixes as suggested by https://github.com/eic/EICrecon/actions/runs/30852065609. Please merge this PR into the branch `wdconinc-fluffy-invention` to resolve failures in PR #2822. Auto-generated by [create-pull-request][1] [1]: https://github.com/peter-evans/create-pull-request Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Switch IrtCherenkovParticleID input wiring from RawHitsAssociations to RawHitsLinks to avoid dangling references after association collections were removed from default output selections. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

for more information, see https://pre-commit.ci

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Suppressed comments (1)

src/services/io/podio/JEventProcessorPODIO.cc:216

PR description/title says all *Associations outputs were removed from the default PODIO output list, but there are still association collections present elsewhere in output_collections (e.g. DRICHRawHitsAssociations, ReconstructedChargedParticleAssociations, MCScatteredElectronAssociations). Please align the PR description with the actual behavior (document exceptions), or remove the remaining association outputs if they are truly no longer needed.

      "ReconstructedParticles",
      "ReconstructedParticleLinks",
      "ReconstructedTruthSeededChargedParticles",
      "ReconstructedTruthSeededChargedParticleLinks",
      "ReconstructedChargedRealPIDParticles",

    m_algo->process({m_aerogel_tracks_input(), m_gas_tracks_input(), m_merged_tracks_input(),
                     m_raw_hits_input(), m_raw_hit_links_input(), m_raw_hit_assoc_input()},
+                     m_raw_hits_input(), m_raw_hit_links_input(), m_raw_hit_assoc_input()},
                    {m_aerogel_particleIDs_output().get(), m_gas_particleIDs_output().get()});
-  }
+}


      {"DRICHAerogelTracks", "DRICHGasTracks", "DRICHMergedTracks", "DRICHRawHits",
       "DRICHRawHitsLinks", "DRICHRawHitsAssociations"},
+       "DRICHRawHitsLinks", "DRICHRawHitsAssociations"
+},
      {"DRICHAerogelIrtCherenkovParticleID", "DRICHGasIrtCherenkovParticleID"}, irt_cfg, app));


Remove duplicated input wiring lines introduced during conflict resolution in DRICH plugin wiring and IrtCherenkovParticleID factory. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/services/io/podio/JEventProcessorPODIO.cc:71

The PR title/description say all *Associations were removed from the default PODIO output list and that IrtCherenkovParticleID was migrated to links. However, JEventProcessorPODIO.cc still contains several *Associations outputs (e.g. DRICHRawHitsAssociations, MCScatteredElectronAssociations, MCNonScatteredElectronAssociations), and IrtCherenkovParticleID still persists RawHitAssociations relations via addToRawHitAssociations(...) (see src/algorithms/pid/IrtCherenkovParticleID.cc:470-473). Please either update the PR description/title to reflect what is actually changed, or complete the link migration/removal for the remaining association outputs so defaults are consistent.

      "CentralTrackerTruthSeeds",
      "CentralTrackingRecHits",
      "CentralTrackingRawHitLinks",
      "CentralTrackSeeds",
      "CentralTrackSeedParameters",

…2877) This PR applies the include-what-you-use fixes as suggested by https://github.com/eic/EICrecon/actions/runs/32326935761. Please merge this PR into the branch `wdconinc-fluffy-invention` to resolve failures in PR #2822. Auto-generated by [create-pull-request][1] [1]: https://github.com/peter-evans/create-pull-request Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Suppressed comments (1)

src/services/io/podio/JEventProcessorPODIO.cc:215

Although many *Associations entries are removed from the default output_collections, the list still includes some association collections (e.g. ReconstructedChargedParticleAssociations, MCScatteredElectronAssociations, MCNonScatteredElectronAssociations, and also DRICHRawHitsAssociations earlier). This conflicts with the PR description/title stating that *Associations entries are removed from the default PODIO output. Please either remove the remaining association collections as well, or update the PR description (and/or add an inline comment) to clarify which association collections intentionally remain and why.

      "ReconstructedParticles",
      "ReconstructedParticleLinks",
      "ReconstructedTruthSeededChargedParticles",
      "ReconstructedTruthSeededChargedParticleLinks",

### Briefly, what does this PR introduce? Please link to any relevant presentations or discussions. This PR isolates the DRICH IRT link migration from eic#2822 into a standalone change for focused review. It updates IrtCherenkovParticleID to consume `DRICHRawHitsLinks` (using `getFrom()/getTo()` for link access) while preserving `addToRawHitAssociations` output behavior by still using association objects. DRICH wiring/factory inputs are updated to pass both links and associations. ### What is the urgency of this PR? - [ ] High (please describe reason below) - [x] Medium - [ ] Low ### What kind of change does this PR introduce? - [x] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Optimization (issue #__) - [ ] Updated parameters, constants (issue #__) - [ ] Updated documentation - [ ] other: __ ### Please check if any of the following apply - [ ] This PR requires changes to geometry (epic PR: __) - [ ] This PR requires changes to EDM4eic (EDM PR: __) - [ ] This PR introduces breaking changes. Please describe changes users need to make below. - [ ] This PR changes default behavior. Please describe changes below. - [x] AI was used in preparing this PR. Please describe usage below. Used Copilot CLI to split the change, apply review-requested fixes, and update wording/comments for correctness. --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: epic-capybara <139920704+epic-capybara@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Chandradoy Chatterjee <chandradoy.chatterjee@ts.infn.it>

Copilot AI lite review requested due to automatic review settings August 3, 2026 20:20

wdconinc changed the title ~~Remove unused *Associations entries from PODIO output collections~~ fix: remove unused *Associations entries from PODIO output collections Aug 3, 2026

wdconinc requested review from a team and veprbl August 3, 2026 20:23

Copilot started reviewing on behalf of wdconinc August 3, 2026 20:25 View session

Copilot AI reviewed Aug 3, 2026

View reviewed changes

wdconinc requested review from Copilot and removed request for Copilot August 3, 2026 20:39

wdconinc enabled auto-merge August 3, 2026 20:39

Copilot started reviewing on behalf of wdconinc August 3, 2026 20:44 View session

wdconinc requested review from Copilot and removed request for Copilot August 3, 2026 20:50

Copilot started reviewing on behalf of wdconinc August 3, 2026 20:54 View session

wdconinc changed the title ~~fix: remove unused *Associations entries from PODIO output collections~~ fix: remove *Associations entries from PODIO output collections Aug 3, 2026

wdconinc changed the title ~~fix: remove *Associations entries from PODIO output collections~~ fix: remove *Associations from PODIO output collections Aug 3, 2026

epic-capybara mentioned this pull request Aug 3, 2026

fix: remove unused *Associations entries from PODIO output collections (fix: iwyu) #2825

Merged

Copilot AI review requested due to automatic review settings August 3, 2026 22:12

Copilot started reviewing on behalf of wdconinc August 3, 2026 22:12 View session

Copilot AI previously approved these changes Aug 3, 2026

View reviewed changes

wdconinc requested review from Copilot and removed request for Copilot August 3, 2026 22:31

github-actions Bot added the topic: PID Relates to PID reconstruction label Aug 3, 2026

Copilot started reviewing on behalf of wdconinc August 3, 2026 22:33 View session

wdconinc requested review from Copilot and removed request for Copilot August 3, 2026 22:47

Copilot started reviewing on behalf of wdconinc August 3, 2026 22:48 View session

Copilot AI review requested due to automatic review settings August 3, 2026 23:35

Copilot started reviewing on behalf of wdconinc August 3, 2026 23:36 View session

Copilot AI reviewed Aug 3, 2026

View reviewed changes

Comment thread src/services/io/podio/JEventProcessorPODIO.cc Outdated

wdconinc and others added 8 commits August 19, 2026 21:55

fix: rm ReconstructedChargedParticleAssociations

6a08092

Removed 'ReconstructedChargedParticleAssociations' from the list.

fix: add MC(Non)?ScatteredElectronLinks (keep *Associations)

97a5868

fix: re-add ReconstructedChargedParticleAssociations

64dfe25

[pre-commit.ci] auto fixes from pre-commit.com hooks

820a9cb

for more information, see https://pre-commit.ci

fix: re-add DRICHRawHitsAssociations

c54f4cb

fix: rm TOF*SharedHitAssociations

c8204ec

Copilot AI review requested due to automatic review settings August 20, 2026 02:57

wdconinc force-pushed the wdconinc-fluffy-invention branch from e99c62c to c8204ec Compare August 20, 2026 02:57

[pre-commit.ci] auto fixes from pre-commit.com hooks

8208378

for more information, see https://pre-commit.ci

Copilot started reviewing on behalf of wdconinc August 20, 2026 03:00 View session

Copilot AI reviewed Aug 20, 2026

View reviewed changes

fix: clean duplicated lines after rebase conflict resolution

8dc32b4

Remove duplicated input wiring lines introduced during conflict resolution in DRICH plugin wiring and IrtCherenkovParticleID factory. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings August 20, 2026 03:04

Copilot started reviewing on behalf of wdconinc August 20, 2026 03:05 View session

Copilot AI reviewed Aug 20, 2026

View reviewed changes

epic-capybara mentioned this pull request Aug 20, 2026

fix: remove *Associations from PODIO output collections (fix: iwyu) #2877

Merged

Copilot AI review requested due to automatic review settings August 20, 2026 03:43

Copilot started reviewing on behalf of wdconinc August 20, 2026 03:44 View session

Copilot AI reviewed Aug 20, 2026

View reviewed changes

wdconinc temporarily deployed to github-pages August 20, 2026 04:56 — with GitHub Actions Inactive

veprbl mentioned this pull request Aug 28, 2026

[Cross references] Transition from Associations to Links #2917

Open

8 tasks

Navigation Menu

Uh oh!

fix: remove *Associations from PODIO output collections - #2822

fix: remove *Associations from PODIO output collections#2822
wdconinc wants to merge 13 commits into
mainfrom
wdconinc-fluffy-invention

wdconinc commented Aug 3, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

wdconinc commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dependencies

Description

Changes

Impact

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Not ready to approve

Suppressed comments (1)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Ready to approve

Suppressed comments (1)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Not ready to approve

Suppressed comments (1)

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

wdconinc commented Aug 3, 2026 •

edited

Loading