Update benchmark examples to podio link naming - #11
Conversation
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files or spoofing. It should be safe to Approve and Run the workflows that need maintainer approval. |
wdconinc
left a comment
There was a problem hiding this comment.
Not sure why the duplication of uchannelrho.cxx, but this seems like a fine change. The benchmark is also not actually in any of the benchmark repositories...
There was a problem hiding this comment.
Pull request overview
Updates the uchannelrho.cxx benchmark example(s) to follow the current podio “Links” branch naming in the ROOT event tree, replacing the deprecated “Associations” branches so the tutorial matches current EICrecon output.
Changes:
- Switched the example’s association/relationship branches from
ReconstructedChargedParticleAssociations.*/*_Associations_*to"_ReconstructedChargedParticleLinks_{from,to}.index". - Standardized the link index reader types to
unsigned int. - Updated inline comments (episode copy) to describe the link-based relationship model.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| learners/files/uchannelrho.cxx | Updates the reader branch names to *_Links_{from,to}.index in the learner copy. |
| episodes/files/uchannelrho.cxx | Updates branch names and clarifies comments describing how link indices map between reco and MC collections. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
… script Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
wdconinc
left a comment
There was a problem hiding this comment.
Looks all good to me now.
Auto-generated via `{sandpaper}`
Source : 78e70ff
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2026-09-03 15:04:34 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : 6575c10
Branch : main
Author : Wouter Deconinck <wdconinc@gmail.com>
Time : 2026-09-03 15:02:40 +0000
Message : Merge pull request #11 from eic/copilot/transition-from-associations-to-links
Update benchmark examples to podio link naming
The benchmark examples were still reading the old podio association branches, which no longer match the current data model. This left the examples pointing at
Associations.*andrecID/simIDfields while the generated event data exposes link collections with*_Links_from.indexand*_Links_to.index.unsigned intand moved to the current*_Links_from/*_Links_tonaming convention.