Skip to content

Update benchmark examples to podio link naming - #11

Merged
wdconinc merged 3 commits into
mainfrom
copilot/transition-from-associations-to-links
Sep 3, 2026
Merged

Update benchmark examples to podio link naming#11
wdconinc merged 3 commits into
mainfrom
copilot/transition-from-associations-to-links

Conversation

Copilot AI commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

The benchmark examples were still reading the old podio association branches, which no longer match the current data model. This left the examples pointing at Associations.* and recID/simID fields while the generated event data exposes link collections with *_Links_from.index and *_Links_to.index.

  • Changes
    • Updated the C++ examples to read the link collections instead of the deprecated association branches.
    • Switched the association index arrays to unsigned int and moved to the current *_Links_from / *_Links_to naming convention.
    • Reworded the inline comments to describe the link-based relationship model that matches the ROOT tree layout.
TTreeReaderArray<unsigned int> rec_id = {tree_reader, "_ReconstructedChargedParticleLinks_from.index"};
TTreeReaderArray<unsigned int> sim_id = {tree_reader, "_ReconstructedChargedParticleLinks_to.index"};
  • Scope
    • Applied in both the episode source and the learner copy so the benchmark instructions stay aligned with the current EICrecon output format.

Copilot AI linked an issue Aug 30, 2026 that may be closed by this pull request
Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Copilot AI changed the title [WIP] Update associations to links in code Update benchmark examples to podio link naming Aug 30, 2026
Copilot AI requested a review from wdconinc August 30, 2026 16:11
@github-actions

Copy link
Copy Markdown
Contributor

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files or spoofing.

It should be safe to Approve and Run the workflows that need maintainer approval.

@wdconinc wdconinc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why the duplication of uchannelrho.cxx, but this seems like a fine change. The benchmark is also not actually in any of the benchmark repositories...

@wdconinc
wdconinc marked this pull request as ready for review August 30, 2026 16:54
Copilot AI lite review requested due to automatic review settings August 30, 2026 16:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the uchannelrho.cxx benchmark example(s) to follow the current podio “Links” branch naming in the ROOT event tree, replacing the deprecated “Associations” branches so the tutorial matches current EICrecon output.

Changes:

  • Switched the example’s association/relationship branches from ReconstructedChargedParticleAssociations.* / *_Associations_* to "_ReconstructedChargedParticleLinks_{from,to}.index".
  • Standardized the link index reader types to unsigned int.
  • Updated inline comments (episode copy) to describe the link-based relationship model.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
learners/files/uchannelrho.cxx Updates the reader branch names to *_Links_{from,to}.index in the learner copy.
episodes/files/uchannelrho.cxx Updates branch names and clarifies comments describing how link indices map between reco and MC collections.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread learners/files/uchannelrho.cxx
… script

Co-authored-by: wdconinc <4656391+wdconinc@users.noreply.github.com>
Copilot AI requested a review from wdconinc August 30, 2026 17:05

@wdconinc wdconinc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me now.

@wdconinc
wdconinc requested review from aprozo and sjdkay August 30, 2026 17:10

@sjdkay sjdkay left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me too.

@wdconinc
wdconinc merged commit 6575c10 into main Sep 3, 2026
5 checks passed
github-actions Bot pushed a commit that referenced this pull request Sep 3, 2026
Auto-generated via `{sandpaper}`
Source  : 6575c10
Branch  : main
Author  : Wouter Deconinck <wdconinc@gmail.com>
Time    : 2026-09-03 15:02:40 +0000
Message : Merge pull request #11 from eic/copilot/transition-from-associations-to-links

Update benchmark examples to podio link naming
github-actions Bot pushed a commit that referenced this pull request Sep 3, 2026
Auto-generated via `{sandpaper}`
Source  : 78e70ff
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2026-09-03 15:04:34 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : 6575c10
Branch  : main
Author  : Wouter Deconinck <wdconinc@gmail.com>
Time    : 2026-09-03 15:02:40 +0000
Message : Merge pull request #11 from eic/copilot/transition-from-associations-to-links

Update benchmark examples to podio link naming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Transition from Associations to Links

4 participants