Skip to content

Alive monitor refactor cleanup - #571

Merged
MaciejKaszynski merged 7 commits into
eclipse-score:mainfrom
etas-contrib:feature/alive-mon-refactor-cleanup
Sep 7, 2026
Merged

Alive monitor refactor cleanup#571
MaciejKaszynski merged 7 commits into
eclipse-score:mainfrom
etas-contrib:feature/alive-mon-refactor-cleanup

Conversation

@WilliamRoebuck

Copy link
Copy Markdown
Contributor

Small cleanup after #522. The last 2 commits are the new changes.

  • Removed supervision control client folder and distributed files within to alive monitor
  • Added getConnectionId() to SupervisionHandle
  • Renamed start/stop methods to startMonitoring/stopMonitoring

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.7.0) and connecting to it...
INFO: Invocation ID: 2d1c4d59-2ec8-49e1-bb0e-9beb198e75b5
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (67 packages loaded, 10 targets configured)

Analyzing: target //:license-check (142 packages loaded, 1852 targets configured)

Analyzing: target //:license-check (157 packages loaded, 6732 targets configured)

Analyzing: target //:license-check (161 packages loaded, 9365 targets configured)

Analyzing: target //:license-check (164 packages loaded, 9491 targets configured)

Analyzing: target //:license-check (171 packages loaded, 9661 targets configured)

INFO: Analyzed target //:license-check (173 packages loaded, 11555 targets configured).
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 20.286s, Critical Path: 0.23s
INFO: 16 processes: 4 disk cache hit, 12 internal.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@WilliamRoebuck
WilliamRoebuck force-pushed the feature/alive-mon-refactor-cleanup branch from 082e24e to eed747a Compare August 31, 2026 12:13
@WilliamRoebuck
WilliamRoebuck force-pushed the feature/alive-mon-refactor-cleanup branch from eed747a to 9d9cbe8 Compare August 31, 2026 12:18
MaciejKaszynski
MaciejKaszynski previously approved these changes Sep 7, 2026
}

/// @brief Get the name of the IPC file alive indications are sent to.
std::string_view getConnectionId() const noexcept override

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is named getConnectionId but it returns a path, should it be called something like getIPCPath instead?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the moment its a shared memory path. However, in the future this could be a mw::com instance specifier as there are requests to remove custom IPC implementation from the launch manager code and only use mw::com/message_passing

@NicolasFussberger
NicolasFussberger deployed to workflow-approval September 7, 2026 12:59 — with GitHub Actions Active
@NicolasFussberger
NicolasFussberger deployed to workflow-approval September 7, 2026 12:59 — with GitHub Actions Active
@WilliamRoebuck
WilliamRoebuck deployed to workflow-approval September 7, 2026 13:23 — with GitHub Actions Active
@WilliamRoebuck
WilliamRoebuck deployed to workflow-approval September 7, 2026 13:23 — with GitHub Actions Active
@WilliamRoebuck
WilliamRoebuck deployed to workflow-approval September 7, 2026 13:52 — with GitHub Actions Active
@WilliamRoebuck
WilliamRoebuck deployed to workflow-approval September 7, 2026 13:52 — with GitHub Actions Active
@MaciejKaszynski
MaciejKaszynski merged commit 54526b3 into eclipse-score:main Sep 7, 2026
27 of 31 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in LCM - Lifecycle & Health FT Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants