Processes construct their own supervision - #522
Merged
MaciejKaszynski merged 31 commits intoSep 7, 2026
Merged
Conversation
WilliamRoebuck
requested a deployment
to
workflow-approval
August 24, 2026 16:39 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
August 24, 2026 16:39 — with
GitHub Actions
Waiting
Contributor
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
WilliamRoebuck
force-pushed
the
feature/process-makes-supervision
branch
from
August 27, 2026 16:08
663cb89 to
2a5e575
Compare
WilliamRoebuck
requested a deployment
to
workflow-approval
August 27, 2026 16:08 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
August 27, 2026 16:08 — with
GitHub Actions
Waiting
WilliamRoebuck
force-pushed
the
feature/process-makes-supervision
branch
from
August 28, 2026 08:56
2a5e575 to
5c1f0cc
Compare
WilliamRoebuck
requested a deployment
to
workflow-approval
August 28, 2026 08:56 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
August 28, 2026 08:56 — with
GitHub Actions
Waiting
WilliamRoebuck
force-pushed
the
feature/process-makes-supervision
branch
from
August 28, 2026 08:59
5c1f0cc to
8c2033c
Compare
WilliamRoebuck
requested a deployment
to
workflow-approval
August 28, 2026 08:59 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
August 28, 2026 08:59 — with
GitHub Actions
Waiting
WilliamRoebuck
marked this pull request as ready for review
August 28, 2026 08:59
WilliamRoebuck
requested review from
FScholPer,
MaciejKaszynski,
NicolasFussberger,
anmittag,
antonkri,
pawelrutkaq and
ramceb
as code owners
August 28, 2026 08:59
WilliamRoebuck
force-pushed
the
feature/process-makes-supervision
branch
from
August 28, 2026 09:42
8c2033c to
9e9809f
Compare
WilliamRoebuck
requested a deployment
to
workflow-approval
August 28, 2026 09:43 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
August 28, 2026 09:43 — with
GitHub Actions
Waiting
danth
suggested changes
Aug 28, 2026
danth
left a comment
Member
There was a problem hiding this comment.
This looks like a good cleanup, just a few small tweaks 😄
WilliamRoebuck
force-pushed
the
feature/process-makes-supervision
branch
from
August 28, 2026 11:45
9e9809f to
fdec3cd
Compare
WilliamRoebuck
requested a deployment
to
workflow-approval
August 28, 2026 11:45 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
August 28, 2026 11:45 — with
GitHub Actions
Waiting
danth
approved these changes
Aug 28, 2026
WilliamRoebuck
requested a deployment
to
workflow-approval
September 4, 2026 09:33 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
September 4, 2026 09:33 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
September 4, 2026 09:40 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
September 4, 2026 09:40 — with
GitHub Actions
Waiting
MaciejKaszynski
requested changes
Sep 4, 2026
…into feature/process-makes-supervision
WilliamRoebuck
requested a deployment
to
workflow-approval
September 4, 2026 13:17 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
September 4, 2026 13:17 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
September 4, 2026 13:18 — with
GitHub Actions
Waiting
WilliamRoebuck
requested a deployment
to
workflow-approval
September 4, 2026 13:18 — with
GitHub Actions
Waiting
…into feature/process-makes-supervision
…into feature/process-makes-supervision
Contributor
|
Looks great me! Feel free defer any open comments to the already open follow-up PR. |
MaciejKaszynski
approved these changes
Sep 7, 2026
NicolasFussberger
approved these changes
Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of the refactoring started in #477. This PR moves alive supervision construction to the ProcessInfoNode constructor.
In addition, it:
SupervisionHandle, this is no longer neededgetTimeForReportsupervision_control_clientTODO
PhmDaemon::constructmethod. This really just needs to reserve the size of a vector and LM should calculate what size to reserve