Skip to content

Remove Linux constraint from require_typed_memory #539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devendrapat wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Remove Linux constraint from require_typed_memory #539

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
099b7f6
Remove Linux constraint from require_typed_memory
devendrapat Sep 2, 2026
a75a243
Merge branch 'eclipse-score:main' into depa_remove_linux_constraint
devendrapat Sep 8, 2026
c533b52
Try-out adding strange configuration values to keep config setting di…
Sep 8, 2026
700bf72
Make require_typed_memory as false with private bool
Sep 10, 2026
83bef30
Make enable_typed_memory public
Sep 11, 2026
1554cfd
Merge branch 'main' into depa_remove_linux_constraint
devendrapat Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions score/analysis/tracing/generic_trace_library/flags/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,24 @@
#
# SPDX-License-Identifier: Apache-2.0
# *******************************************************************************
load("@bazel_skylib//rules:common_settings.bzl", "bool_flag")

bool_flag(
name = "enable_typed_memory",
build_setting_default = False,
visibility = [
"//visibility:public",
],
)

# This config_setting is not used in this repository and should be always False
config_setting(
name = "require_typed_memory", #This is a stub and should always be false
name = "require_typed_memory",
constraint_values = [
"@platforms//os:qnx",
"@platforms//os:linux", # Contradicts qnx — ensures this config_setting never matches (stub)

@hoppe-and-dreams hoppe-and-dreams Sep 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do this, all S-CORE LoLa builds on QNX would go to typed memory. I do not think this is the intended (and aligned) consequence.

If it is indeed the desired outcome, at least the comment 3 lines above must be changed to match what the code does.

@devendrapat devendrapat Sep 11, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @hoppe-and-dreams,
Changes were made to use a bool_flag constraint to set require_typed_memory flag so that score_communication can depend on it without issues. Also the comment above was modified a bit to convey that the flag is not used anywhere in the repository, and the bool_flag is False by default.

],
flag_values = {
":enable_typed_memory": "True",
},
visibility = ["//visibility:public"],
)