Remove Linux constraint from require_typed_memory - #539
Draft
devendrapat wants to merge 3 commits into
Draft
Conversation
Removed contradictory Linux constraint from require_typed_memory config_setting as it is blocking score_communication from using this config_setting. Signed-off-by: devendrapat <76650287+devendrapat@users.noreply.github.com>
devendrapat
requested review from
4og,
antonkri,
arkjedrz,
fbaeuerle and
pawelrutkaq
as code owners
September 2, 2026 09:32
github-actions
Bot
added
comp-tracing
devendrapat
marked this pull request as draft
September 2, 2026 09:33
Member
|
@hoppe-and-dreams please have a look |
Contributor
|
Documentation preview for this pull request is available at: |
hoppe-and-dreams
suggested changes
Sep 2, 2026
| name = "require_typed_memory", #This is a stub and should always be false | ||
| constraint_values = [ | ||
| "@platforms//os:qnx", | ||
| "@platforms//os:linux", # Contradicts qnx — ensures this config_setting never matches (stub) |
Contributor
There was a problem hiding this comment.
If we do this, all S-CORE LoLa builds on QNX would go to typed memory. I do not think this is the intended (and aligned) consequence.
If it is indeed the desired outcome, at least the comment 3 lines above must be changed to match what the code does.
devendrapat
requested a deployment
to
workflow-approval
September 8, 2026 10:20 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
devendrapat
requested a deployment
to
workflow-approval
September 8, 2026 10:20 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
devendrapat
requested a deployment
to
workflow-approval
September 8, 2026 10:20 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
devendrapat
requested a deployment
to
workflow-approval
September 8, 2026 10:20 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
devendrapat
requested a deployment
to
workflow-approval
September 8, 2026 10:37 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
devendrapat
requested a deployment
to
workflow-approval
September 8, 2026 10:37 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
devendrapat
requested a deployment
to
workflow-approval
September 8, 2026 10:37 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
devendrapat
requested a deployment
to
workflow-approval
September 8, 2026 10:37 — with
GitHub Actions
Waiting
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed contradictory Linux constraint from require_typed_memory config_setting as it is blocking score_communication from using this config_setting, as this was blocking score_communication from using the config_setting in their code.
Please refer eclipse-score/communication#1022 for the error faced by score_communication while using require_typed_memory_config_setting.