Skip to content

Remove Linux constraint from require_typed_memory - #539

Open
devendrapat wants to merge 6 commits into
eclipse-score:mainfrom
devendrapat:depa_remove_linux_constraint
Open

Remove Linux constraint from require_typed_memory#539
devendrapat wants to merge 6 commits into
eclipse-score:mainfrom
devendrapat:depa_remove_linux_constraint

Conversation

@devendrapat

@devendrapat devendrapat commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Removed contradictory Linux constraint from require_typed_memory config_setting as it is blocking score_communication from using this config_setting, as this was blocking score_communication from using the config_setting in their code. In this PR, changes were made to use a bool_flag constraint to set require_typed_memory flag so that score_communication can depend on it without issues.

Please refer eclipse-score/communication#1022 for the error faced by score_communication while using require_typed_memory_config_setting.

@devendrapat
Remove Linux constraint from require_typed_memory
099b7f6 
Removed contradictory Linux constraint from require_typed_memory config_setting as it is blocking score_communication from using this config_setting.

Signed-off-by: devendrapat <76650287+devendrapat@users.noreply.github.com>
@github-project-automation github-project-automation Bot moved this to In Progress in BAS - Baselibs FT Sep 2, 2026
@devendrapat
devendrapat deployed to workflow-approval September 2, 2026 09:32 — with GitHub Actions Active
@devendrapat
devendrapat deployed to workflow-approval September 2, 2026 09:32 — with GitHub Actions Active
@devendrapat
devendrapat deployed to workflow-approval September 2, 2026 09:32 — with GitHub Actions Active
@devendrapat
devendrapat deployed to workflow-approval September 2, 2026 09:32 — with GitHub Actions Active
@github-actions github-actions Bot added comp-tracing Related to score/analysis bazel Bazel and Starlark build files labels Sep 2, 2026
@devendrapat
devendrapat marked this pull request as draft September 2, 2026 09:33
@4og

4og commented Sep 2, 2026

Copy link
Copy Markdown
Member

@hoppe-and-dreams please have a look

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Documentation preview for this pull request is available at:
pr-539: https://eclipse-score.github.io/baselibs/pr-539/

hoppe-and-dreams
hoppe-and-dreams suggested changes Sep 2, 2026
View reviewed changes
Comment thread score/analysis/tracing/generic_trace_library/flags/BUILD
name = "require_typed_memory", #This is a stub and should always be false
constraint_values = [
"@platforms//os:qnx",
"@platforms//os:linux", # Contradicts qnx — ensures this config_setting never matches (stub)

@hoppe-and-dreams hoppe-and-dreams Sep 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do this, all S-CORE LoLa builds on QNX would go to typed memory. I do not think this is the intended (and aligned) consequence.

If it is indeed the desired outcome, at least the comment 3 lines above must be changed to match what the code does.

@devendrapat devendrapat Sep 11, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @hoppe-and-dreams,
Changes were made to use a bool_flag constraint to set require_typed_memory flag so that score_communication can depend on it without issues. Also the comment above was modified a bit to convey that the flag is not used anywhere in the repository, and the bool_flag is False by default.

@devendrapat
devendrapat force-pushed the depa_remove_linux_constraint branch from 98e8f72 to f35d59d Compare September 11, 2026 07:40
@devendrapat
devendrapat force-pushed the depa_remove_linux_constraint branch from f35d59d to 83bef30 Compare September 11, 2026 07:41
@devendrapat
devendrapat marked this pull request as ready for review September 11, 2026 08:06
@devendrapat
devendrapat deployed to workflow-approval September 11, 2026 08:06 — with GitHub Actions Active
@devendrapat
devendrapat deployed to workflow-approval September 11, 2026 08:06 — with GitHub Actions Active
@devendrapat
devendrapat deployed to workflow-approval September 11, 2026 08:06 — with GitHub Actions Active
@devendrapat
devendrapat deployed to workflow-approval September 11, 2026 08:06 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@antonkri antonkri Awaiting requested review from antonkri antonkri is a code owner
@4og 4og Awaiting requested review from 4og 4og is a code owner
@fbaeuerle fbaeuerle Awaiting requested review from fbaeuerle fbaeuerle is a code owner
@pawelrutkaq pawelrutkaq Awaiting requested review from pawelrutkaq pawelrutkaq is a code owner
@arkjedrz arkjedrz Awaiting requested review from arkjedrz arkjedrz is a code owner
1 more reviewer
@hoppe-and-dreams hoppe-and-dreams hoppe-and-dreams approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

bazel Bazel and Starlark build files comp-tracing Related to score/analysis

Projects

BAS - Baselibs FT
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@devendrapat @4og @hoppe-and-dreams