Skip to content

Clear the CTabFolder background gradient in setBackground(Color) #3592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vogella wants to merge 1 commit into
base: master
Choose a base branch
from
+32 −1
Open

Clear the CTabFolder background gradient in setBackground(Color) #3592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .../org.eclipse.swt/Eclipse SWT Custom Widgets/common/org/eclipse/swt/custom/CTabFolder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2379,8 +2379,19 @@ public void reskin(int flags) {
}
}

/**
* Sets the background color of the unselected tabs, clearing any background
* gradient set by {@link #setBackground(Color[], int[], boolean)}.
*/
@Override
public void setBackground (Color color) {
gradientColors = null;
gradientPercents = null;
gradientVertical = false;
Comment on lines +2388 to +2390

@akurtakov akurtakov Sep 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than this one, this PR is good to go.

applyBackground(color);
}

private void applyBackground(Color color) {
super.setBackground(color);
updateBkImages(true);
redraw();
Expand Down Expand Up @@ -2501,7 +2512,7 @@ public void setBackground(Color[] colors, int[] percents, boolean vertical) {
gradientPercents[i] = percents[i];
}
gradientVertical = vertical;
setBackground(gradientColors[gradientColors.length-1]);
applyBackground(gradientColors[gradientColors.length-1]);
}

// Refresh with the new settings
Expand Down
20 changes: 20 additions & 0 deletions ...tests/JUnit Tests/org/eclipse/swt/tests/junit/Test_org_eclipse_swt_custom_CTabFolder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,6 +1208,26 @@ public void test_moveItem_sameIndexIsNoOp() {
assertEquals(2, ctabFolder.getSelectionIndex());
}

@Test
public void test_setBackgroundColorClearsGradient() {
createTabFolder(null);
Composite topRight = new Composite(ctabFolder, SWT.NONE);
topRight.setLayout(new FixedSizeLayout(16, 8));
ctabFolder.setTopRight(topRight, SWT.RIGHT);
shell.setSize(400, 300);
shell.layout(true, true);
Color red = shell.getDisplay().getSystemColor(SWT.COLOR_RED);
Color blue = shell.getDisplay().getSystemColor(SWT.COLOR_BLUE);

ctabFolder.setBackground(new Color[] { red, blue }, new int[] { 100 }, true);
assertNotNull(topRight.getBackgroundImage(), "gradient must be handed to the top right control");

ctabFolder.setBackground(blue);
assertNull(topRight.getBackgroundImage(), "solid background must replace the gradient");
assertEquals(blue, topRight.getBackground());
assertEquals(blue, ctabFolder.getBackground());
}

@Test
public void test_moveItem_errorCases() {
createTabFolder(null, 3);
Expand Down
Loading