Conversation
CTabFolder.setBackground(Color) kept a gradient set earlier, so the folder continued to paint gradient images behind the controls in its tab row. Controls without their own colour showed the stale gradient while the others showed the solid colour, which gave toolbar buttons of an inactive part stack mismatched backgrounds. Assisted-by: multiple AI agents and layers of automated tooling 🤖
Contributor
Contributor
Author
|
Without this you end up with artifacts if the old theme used a gradient and the new theme sets the background. 
Corrected: 
|
There was a problem hiding this comment.
🟡 Changes recommended
Gradient state is mutated before superclass argument and widget validation succeeds.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Clears stale CTabFolder gradients when setting a solid background.
Changes:
- Resets gradient state for solid backgrounds.
- Adds regression coverage for tab-row controls.
File summaries
| File | Description |
|---|---|
CTabFolder.java |
Clears gradient state and refreshes backgrounds. |
Test_org_eclipse_swt_custom_CTabFolder.java |
Tests replacing a gradient with a solid color. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+2388
to
+2390
| gradientColors = null; | ||
| gradientPercents = null; | ||
| gradientVertical = false; |
Member
There was a problem hiding this comment.
Other than this one, this PR is good to go.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CTabFolder.setBackground(Color) kept a gradient set earlier, so the folder continued to paint gradient images behind the controls in its tab row. In the IDE this showed up as toolbar buttons of an inactive part stack with mismatched backgrounds: controls without their own colour showed the stale gradient, the others the solid colour. setBackground(Color) now clears the gradient, as CLabel already does. A new CTabFolder test fails without the change and passes with it, and the existing CTabFolder tests pass on GTK.