Fix CI on current black and mypy - #245
Closed
choosen23 wants to merge 1 commit into
Closed
Conversation
Two checks in the tox env currently fail on main, so CI stops before the tests run. This affects every open pull request. `black --check src/` fails because recent releases collapse these short `.format` calls onto a single line. `mypy` fails on the return annotation of `imitation_dynamics`, which declares `Tuple[float, float]` but yields a pair of arrays. No behaviour change.
choosen23
force-pushed
the
run-black-on-src
branch
from
August 26, 2026 09:42
19446bf to
d3058fb
Compare
Author
|
Folded into #244 as its first commit, to keep this to a single pull request. Closing — no need to review both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commands in the tox env currently fail on
main, so CI exits before the tests run. This affectsevery open pull request, not just new ones.
1.
black --check src/— recent black releases collapse these short.formatcalls onto asingle line:
2.
mypy --ignore-missing-imports src/nashpy—imitation_dynamicsis annotatedGenerator[Tuple[float, float], Any, None]but yieldsnash_equilibrium_A, nash_equilibrium_B,which are arrays. Corrected to
Tuple[npt.NDArray, npt.NDArray].No behaviour change in either case. After this, the full tox command set passes locally:
black --check src/ tests/mypy --ignore-missing-imports src/nashpyinterrogate --fail-under 100pytest . --cov=nashpy --cov-fail-under=100+ doctestsflake8 src/ tests/