Skip to content

Expose --no-banner in MTP dotnet test help #55412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Evangelink merged 1 commit into from
Jul 22, 2026
Merged

Expose --no-banner in MTP dotnet test help #55412

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ft.DotNet.Cli.Definitions/Commands/Test/TestCommandDefinition.MicrosoftTestingPlatform.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ public MicrosoftTestingPlatform()
Options.Add(VerbosityOption);
Options.Add(NoRestoreOption);
Options.Add(NoBuildOption);
NoLogoOption.Aliases.Add("--no-banner");

@azat-msft azat-msft Jul 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much knowledge in this code base, but if --no-logo, --nologo, -nologo, /nologo work without calling NoLogoOption.Aliases.Add(), why must it be called for --no-banner?

Options.Add(NoLogoOption);
Options.Add(NoDependenciesOption);
Options.Add(ArtifactsPathOption);
Expand Down
1 change: 1 addition & 0 deletions test/dotnet.Tests/CommandTests/Test/TestCommandParserTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ public void MTPCommandIncludesNoDependenciesOption()
[DataRow("--nologo")]
[DataRow("-nologo")]
[DataRow("/nologo")]
[DataRow("--no-banner")]

@azat-msft azat-msft Jul 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't options like /nobanner, -nobanner be tested as well?

public void MTPCommandTranslatesNoLogoOptionToNoBanner(string optionAlias)
{
var command = new TestCommandDefinition.MicrosoftTestingPlatform();
Expand Down
2 changes: 1 addition & 1 deletion ...t.Tests/CommandTests/Test/snapshots/MTPHelpSnapshotTests.VerifyMTPHelpOutput.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Options:
-v, -verbosity <LEVEL> Set the MSBuild verbosity level. Allowed values are q[uiet], m[inimal], n[ormal], d[etailed], and diag[nostic].
--no-restore Do not restore the project before building. [default: False]
--no-build Do not build the project before testing. Implies --no-restore. [default: False]
-nologo, --no-logo Run test(s), without displaying Microsoft Testplatform banner [default: False]
-nologo, --no-banner, --no-logo Run test(s), without displaying Microsoft Testplatform banner [default: False]
--no-dependencies Do not build project-to-project references and only build the specified project. [default: False]
--artifacts-path <ARTIFACTS_DIR> The artifacts path. All output from the project, including build, publish, and pack output, will go in subfolders under the specified path.
--ucr, --use-current-runtime Use current runtime as the target runtime. [default: False]
Expand Down
Loading