Expose --no-banner in MTP dotnet test help - #55412
Merged
Evangelink merged 1 commit intoJul 22, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 46cf5608-480b-4734-ad57-e9db735e3bca
|
Azure Pipelines: Successfully started running 1 pipeline(s). 2 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the dotnet test Microsoft.Testing.Platform (MTP) command definition so that MTP’s --no-banner switch is explicitly recognized as an alias of the existing --no-logo/-nologo option, and ensures the help output and parser tests reflect that behavior.
Changes:
- Add
--no-banneras an alias on the MTPNoLogoOption. - Update the MTP help snapshot to display
--no-banneralongside existing--no-logoaliases. - Extend parser test coverage to include
--no-bannerin the set of accepted aliases.
Show a summary per file
| File | Description |
|---|---|
| src/Cli/Microsoft.DotNet.Cli.Definitions/Commands/Test/TestCommandDefinition.MicrosoftTestingPlatform.cs | Adds --no-banner as an alias to the MTP no-logo option so it’s recognized by the SDK parser. |
| test/dotnet.Tests/CommandTests/Test/TestCommandParserTests.cs | Adds a test case ensuring --no-banner results in a single forwarded --no-banner test-app argument. |
| test/dotnet.Tests/CommandTests/Test/snapshots/MTPHelpSnapshotTests.VerifyMTPHelpOutput.verified.txt | Updates expected MTP help output to include --no-banner in the option alias list. |
Copilot's findings
- Files reviewed: 3/3 changed files
- Comments generated: 0
Evangelink
enabled auto-merge
July 22, 2026 15:20
YuliiaKovalova
approved these changes
Jul 22, 2026
azat-msft
reviewed
Jul 22, 2026
| [DataRow("--nologo")] | ||
| [DataRow("-nologo")] | ||
| [DataRow("/nologo")] | ||
| [DataRow("--no-banner")] |
Member
There was a problem hiding this comment.
Shouldn't options like /nobanner, -nobanner be tested as well?
| Options.Add(VerbosityOption); | ||
| Options.Add(NoRestoreOption); | ||
| Options.Add(NoBuildOption); | ||
| NoLogoOption.Aliases.Add("--no-banner"); |
Member
There was a problem hiding this comment.
I don't have much knowledge in this code base, but if --no-logo, --nologo, -nologo, /nologo work without calling NoLogoOption.Aliases.Add(), why must it be called for --no-banner?
Member
Author
|
/backport to release/11.0.1xx-preview7 |
Contributor
|
Started backporting to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--no-bannerswitch as an explicit alias ofdotnet test --no-logo--no-bannerin the MTP help outputFollow-up to #55376 and this review comment.
Validation
TestCommandDefinitionTestsandMTPHelpSnapshotTests.VerifyMTPHelpOutputtests